[Bug 2032586] Re: [3.0][bug] Missing a 'grub-install' settings for classic image

[Laider Lai]

Update some key conclusions from the @uplis after some discussion on
Mattermost.

1. It is a bug of this new implementation because before these kind of
images where building fine (if you set aside that the grub conf was
probably a bit broken)

2. To keep the previous behavior, the approach will be to detect the
presence of a "BIOS boot" structure and only run the second grub-install
command if this structure is present. Sadly I can only rely on the
structure name (and check the role is system-boot) which is a bit
brittle.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to Ubuntu Image.
https://bugs.launchpad.net/bugs/2032586

Title:
  [3.0][bug] Missing a 'grub-install' settings for classic image

Status in Ubuntu Image:
  Fix Committed

Bug description:
  Hi,

  We found if the classic image, which is generated by ubuntu-image 3.0,
  uses grub-efi as its boot assets, the classic environment can't update
  its shim.efi and grub.efi files correctly by "sudo apt upgrade".

  Because its grub Debian package manifest settings are not correct.
  Please reference the description from livecd-rootfs: https://git.launchpad.net/ubuntu/+source/livecd-rootfs/tree/live-build/buildd/hooks/02-disk-image-uefi.binary?h=applied/ubuntu/jammy-devel#n101

  Could ubuntu-image 3.0 support to setup correct grub Debian package
  manifest?

  [Reproduce steps]
  1. Build an amd64 classic image that uses grub-efi boot assets
  2. Bootup image and make sure there is a newer shim-signed and grub-efi-amd64-signed
  3. "sudo apt update" and "sudo apt upgrade" to update newer shim-signed and grub-efi-amd64-signed
  4. Check the checksum result for /boot/efi/EFI/ubuntu/shimx64.efi and grubx64.efi
  5. The checksum result still the old version, not newer version

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-image/+bug/2032586/+subscriptions