[Bug 2126679] Re: FTBFS due to removal of nvidiadetection from ubuntu-drivers-common

[Mitchell Augustin]

OK, so I'm gonna double-check this with Jose and Kuba, but I think this
will probably end up being safe to rip out from u-r-u.

Based on https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-
common/+bug/1682291, https://bugs.launchpad.net/ubuntu/+source/ubuntu-
drivers-common/+bug/1808874, and looking through the code path, it seems
like the u-r-u usage of nvidiadetector basically just does this:

Checks for ./ubuntu-drivers-obsolete.pkgs (which no longer exists since artful 1:17.10.5, since this[0] was removed)
u-d-c checks /usr/share/ubuntu-drivers-common/obsolete as a fallback, which does still exist, but only contains nvidia-glx* packages [1], which don't appear to exist in the repos of any supported distribution anymore
If any drivers from that list were installed, it will use NvidiaDetector's install logic to select a new driver to install (which is outdated, and mismatched from what the u-d-c invocations in software-properties-common and subiquity are doing under the hood). (although most likely, supported machines won't have nvidia-glx* installed based on the prior bullet, which should result in this entire section being skipped)


[0]: `./DistUpgrade/build-tarball.sh:cp /usr/share/ubuntu-drivers-common/obsolete ubuntu-drivers-obsolete.pkgs`

```
  * build-tarball.sh: Stop updating ubuntu-drivers-obsolete.pkgs since it
    isn't needed any more see Launchpad bug 1682291 for details.

 -- Brian Murray <brian at ubuntu.com>  Wed, 12 Jul 2017 14:00:20 -0700
```
[1]:
```
cat /usr/share/ubuntu-drivers-common/obsolete                      21:47:17
nvidia-glx
nvidia-glx-new
nvidia-glx-legacy
nvidia-glx-envy
nvidia-glx-new-envy
nvidia-glx-legacy-envy
nvidia-glx-177
nvidia-glx-71
nvidia-glx-190
nvidia-glx-195
```

(we should probably also remove this from u-d-c, after I confirm all of
this with the team)


I'd imagine that even if users do still have ancient nvidia-glx* packages installed, our modern-day packages should conflict (or have transitional packages) to handle this, but that's what I'll confirm with the driver team to be sure.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/2126679

Title:
  FTBFS due to removal of nvidiadetection from ubuntu-drivers-common

Status in ubuntu-release-upgrader package in Ubuntu:
  Confirmed

Bug description:
  Currently, ubuntu-release-upgrader is FTBFS because part of d/rules
  attempts to generate a tarball for dist-upgrader. This breaks when it
  attempts to archive a broken symlink ("NvidiaDetector") which points
  to a directory from the ubuntu-drivers-common package
  ("/usr/lib/python3/dist-packages/NvidiaDetector") fomr which it was
  removed in version 1:0.10.3 [1]. Build failure log from u-r-u is at
  [2].

  [1]: https://launchpad.net/ubuntu/+source/ubuntu-drivers-
  common/1:0.10.3

  [2]: https://launchpadlibrarian.net/820924013/buildlog_ubuntu-
  questing-amd64.ubuntu-release-upgrader_1%3A25.10.6_BUILDING.txt.gz

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/2126679/+subscriptions