[Bug 2112632] Re: efibootmgr: commands Active and Inactive do not work.

[Nick Rosbrook]

Hi,

Sorry this was not reviewed sooner. I have adapted your changes into a
git branch here:
https://git.launchpad.net/~enr0n/ubuntu/+source/efibootmgr/log/?h=lp2112632.
I made the following changes:

1. I added a Bug-Ubuntu: field to the patch headers, pointing to this bug.
2. I slightly modified the format of the Description field to adhere to DEP3 line continuation rules.
3. I added "(LP: #2112632)" to the changelog entry. This helps Launchpad track the status of this bug as the package is uploaded, and eventually is released.

With that, I have uploaded the fix to the development release. In order
to fix the bug in stable releases (i.e. actively supported Ubuntu
releases such as 24.04 LTS), the Stable Release Update (SRU) process
must be followed: https://documentation.ubuntu.com/sru/en/latest/.

Foundations - I think it would be good if someone helped @bucchi out
with the SRU.

Unsubscribing sponsors for now.

** Changed in: efibootmgr (Ubuntu)
       Status: Triaged => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to efibootmgr in Ubuntu.
https://bugs.launchpad.net/bugs/2112632

Title:
  efibootmgr: commands Active and Inactive do not work.

Status in efibootmgr package in Ubuntu:
  Fix Committed
Status in efibootmgr source package in Noble:
  Triaged
Status in efibootmgr source package in Oracular:
  Won't Fix
Status in efibootmgr source package in Plucky:
  Triaged
Status in efibootmgr source package in Questing:
  Triaged

Bug description:
  OS version: Ubuntu 24.04
  package version: 18-1build2

  My PCs has boot entries 0010, 0020 and 0021.

  $ sudo efibootmgr
  BootCurrent: 0010
  Timeout: 1 seconds
  BootOrder: 0020,0010
  Boot0010* NORMAL	HD(1,GPT,XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX,0x800,0x80000)/<<snip>>
  Boot0020* UPDATE	HD(1,GPT,XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX,0x800,0x80000)/<<snip>>
  Boot0021* UEFI: TOSHIBA, Partition 1	PciRoot(0x0)/Pci(0x14,0x0)/USB(16,0)/HD(1,GPT,XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX,0x800,0x80000)0000424f

  I tried to active/inactive 10 or 20 entry. But these are not found.

  $ sudo efibootmgr -A -b 0010
  efibootmgr: Boot entry 10 not found
  Could not set active state for Boot0010: No such file or directory
  $ sudo efibootmgr -A -b 0020
  efibootmgr: Boot entry 20 not found
  Could not set active state for Boot0020: No such file or directory
  $ sudo efibootmgr -a -b 0010
  efibootmgr: Boot entry 10 not found
  Could not set active state for Boot0010: No such file or directory
  $ sudo efibootmgr -a -b 0020
  efibootmgr: Boot entry 20 not found
  Could not set active state for Boot0020: No such file or directory

  I investigated the cause and found a problem with the get_entry()
  function in src/efibootmgr.c.

  static var_entry_t *
  get_entry(list_t *entries, uint16_t num)
  {
   list_t *pos;
   var_entry_t *entry = NULL;

   list_for_each(pos, entries) {
    entry = list_entry(pos, var_entry_t, list);
    if (entry->num != num) {
     entry = NULL;
     continue;
    }
   }

   return entry;
  }

  This code does not break the loop when an entry is found.
  Therefore, NULL is returned unless the matching entry is the last one.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/efibootmgr/+bug/2112632/+subscriptions