[Bug 2129819] [NEW] apt 3.0 solver accidentally removes dependencies of metapackages when removing a metapackage due to removing one of its dependencies.

[Julian Andres Klode]

Public bug reported:

[Impact]
The autoremove command inadvertently removed more packages than necessary as the manual bit was not correctly moved from meta packages to their dependencies when the metapackage was being removed due to a dependency being removed.

[Test plan]
APT's rigorous integration and regression test suite will include a fix for this instance, ensuring it does not happen again.

[Where problems could occur]
The patch changes the code that marks packages for deletion to record that they were being marked for removal as a result of exhausting all options to installing them and hence backtracking.

This means we now pass FromUser=false to the MarkDelete() in more
places, which can lead to bugs like

https://salsa.debian.org/apt-
team/apt/-/merge_requests/527/diffs?commit_id=254ba81131a5360b15905dad8174cea640b8736d

Which cause the translation of the solver result to be incomplete,
potentially causing a regression in reporting quality for errors (but
not correctness).

However, while a regression in reporting quality would be unfortunate,
removing packages we should not be removing is worse.

** Affects: apt (Ubuntu)
     Importance: Undecided
         Status: Triaged

** Affects: apt (Ubuntu Questing)
     Importance: Undecided
         Status: Triaged

** Affects: apt (Ubuntu Resolute)
     Importance: Undecided
         Status: Triaged

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apt in Ubuntu.
https://bugs.launchpad.net/bugs/2129819

Title:
  apt 3.0 solver accidentally removes dependencies of metapackages when
  removing a metapackage due to removing one of its dependencies.

Status in apt package in Ubuntu:
  Triaged
Status in apt source package in Questing:
  Triaged
Status in apt source package in Resolute:
  Triaged

Bug description:
  [Impact]
  The autoremove command inadvertently removed more packages than necessary as the manual bit was not correctly moved from meta packages to their dependencies when the metapackage was being removed due to a dependency being removed.

  [Test plan]
  APT's rigorous integration and regression test suite will include a fix for this instance, ensuring it does not happen again.

  [Where problems could occur]
  The patch changes the code that marks packages for deletion to record that they were being marked for removal as a result of exhausting all options to installing them and hence backtracking.

  This means we now pass FromUser=false to the MarkDelete() in more
  places, which can lead to bugs like

  https://salsa.debian.org/apt-
  team/apt/-/merge_requests/527/diffs?commit_id=254ba81131a5360b15905dad8174cea640b8736d

  Which cause the translation of the solver result to be incomplete,
  potentially causing a regression in reporting quality for errors (but
  not correctness).

  However, while a regression in reporting quality would be unfortunate,
  removing packages we should not be removing is worse.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt/+bug/2129819/+subscriptions