[Bug 2150178] Re: update-manager theoretically crashes due to Gtk.Window.run() in BuilderDialog

[Arnab Patra]

Thanks for the detailed analysis — that clarifies things a lot.

You're right, forcing the call shows that BuilderDialog.run() depends on
window_dialog, which isn't guaranteed to exist due to the way the UI is
loaded with "pane_dialog" as the root. That makes the code effectively
unreachable in practice.

Given that, I agree this isn't a real runtime crash but rather stale
code.

I can work on a cleanup patch to remove BuilderDialog.run() and
references to window_dialog, or alternatively audit this area for
smaller real issues (e.g. deprecated GTK APIs).

Let me know if you have a preference for which direction would be more
useful.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-manager in Ubuntu.
https://bugs.launchpad.net/bugs/2150178

Title:
  update-manager theoretically crashes due to Gtk.Window.run() in
  BuilderDialog

Status in update-manager package in Ubuntu:
  Triaged

Bug description:
  In UpdateManager/Dialogs.py, BuilderDialog.run() calls
  self.window_dialog.run(), which causes a crash because
  Gtk.Window does not support the run() method (only Gtk.Dialog does).

  This leads to a runtime error when the dialog is shown.

  Proposed fix:
  Replace run() with show_all(), since update-manager already runs
  inside the GTK main loop.

  Patch attached.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/2150178/+subscriptions