[Bug 2150439] Re: Refactor UpdateManager.py: improve logging, structure, and error handling
Nathan Teodosio
2150439 at bugs.launchpad.net
Thu Apr 30 07:32:36 UTC 2026
There are many instances of style modifications, e.g.
-->
self.initial_focus_id = self.connect(
- "focus-in-event", self.on_initial_focus_in
+ "focus-in-event",
+ self.on_initial_focus_in
)
<--
These only make the already big patch bigger, unnecessarily adding to
the reviewer's load.
In any case, I do not think we should be refactoring this code base,
which is arguably legacy. If there is a concrete and observable bug, a
targeted change is very welcome, otherwise I would advise against
changes.
--
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-manager in Ubuntu.
https://bugs.launchpad.net/bugs/2150439
Title:
Refactor UpdateManager.py: improve logging, structure, and error
handling
Status in update-manager package in Ubuntu:
New
Bug description:
This patch refactors UpdateManager.py to improve readability,
maintainability, and robustness.
Changes include:
- Structured imports into logical sections
- Added docstrings for better documentation
- Replaced print statements with logging
- Improved exception handling
- Safer attribute access using getattr
No functional changes are intended.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/2150439/+subscriptions
More information about the foundations-bugs
mailing list