[Bug 2125535] Re: makeself archive failing md5sum validation [dd: partial write to slow reader]

[Andrus Suvalau]

The bug was not fixed completely. rust-coreutils’s dd still suffers from
partial writes/reads.

Running makeself packages with the --noprogress flag fails the MD5
check:

./VirtualBox-7.2.4-170995-Linux_amd64.run --noprogress
Verifying archive integrity...Error in MD5 checksums: 9dc82c07dffca651393b0b6c298b1808 is different from 693ffa7cb191f04d9eb0ded99a6e7c96

It can also be easily reproduced in the following way.
First run:
dd if=/dev/random count=1 | dd of=/dev/null count=1
0+1 records in
0+1 records out
216 bytes copied, 0.00075778 s, 216 kB/s
1+0 records in
1+0 records out
512 bytes copied, 0.00035847 s, 512 kB/s

Second run:
dd if=/dev/random count=1 | dd of=/dev/null count=1
1+0 records in
1+0 records out
0+1 records in
0+1 records out
512 bytes copied, 0.000438973 s, 512 kB/s
254 bytes copied, 0.000450006 s, 254 kB/s

Note: Each run reports a different number of bytes copied.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to rust-coreutils in Ubuntu.
https://bugs.launchpad.net/bugs/2125535

Title:
  makeself archive failing md5sum validation [dd: partial write to slow
  reader]

Status in Release Notes for Ubuntu:
  New
Status in makeself package in Ubuntu:
  Confirmed
Status in rust-coreutils package in Ubuntu:
  Fix Released
Status in makeself source package in Questing:
  Confirmed
Status in rust-coreutils source package in Questing:
  Fix Released
Status in makeself source package in Resolute:
  Confirmed
Status in rust-coreutils source package in Resolute:
  Fix Released

Bug description:
  [Impact]
  Users are unable to install VirtualBox guest extensions amongst other packages, due to dd inadvertently not writing all file content to slow readers, resulting in the makeself archives failing their selfcheck.

  [Test plan]
  Get the ISO from the virtualbox-guest-additions-iso package, and try to run VBoxLinuxAdditions.run inside of it.

  Failure: The script fails at the self-check
  Verifying archive integritiy... 100% Error in MD5 checksums: ...

  Pass: The script passes the self-check
  Verifying archive integrity...  100%   MD5 checksums are OK. All good.
  Uncompressing VirtualBox 7.2.2 Guest Additions for Linux  100%

  To cover regressions, rust-coreutils contains a test suite and GNU
  coreutils contain a test suite, which is also run against the Rust
  coreutils and will be triggered by the test.

  [Where problems could occur]
  Given that this covers retrying, it's plausible it might retry indefinitely in some corner cases, but the change is minimal:

  -                    // take iflags.fullblock as oflags shall not have this option
  -                    if (base_idx >= full_len) || !self.settings.iflags.fullblock {
  +                    if base_idx >= full_len {

  It's essentially changing the behavior to be like fullblock for
  writes, always, so it should be fine as you can already set this
  option.

  It seems the newly added tests in the test suite do not adequately
  test the fix, this is still a point of contention for merging it
  upstream, but must not block us from fixing this.

  [Original bug report]
  Still trying to find causes, but this sympton:

  for a 25.10 guest image, the virtualbox guest additions install
  (VBoxLinuxAdditions.run from the official ISO) fails checksum.  The
  Linux installer script is a makeself self-extracting archive (makeself
  is a Ubuntu package, though I don't know if the VirtualBox team uses
  Ubuntu to generate the archive). The output of trying to run this
  script is:

  # ./VBoxLinuxAdditions.run --noexec
  Verifying archive integritiy... 100% Error in MD5 checksums: c8ea742682d7024e581f916c763818c9 is different from 201ccc47587bb1c28745279e8b7fdd30

  The 201ccc signature is the one embedded in the script. On a 25.04
  system, there is no checksum complaint:

  # ./VBoxLinuxAdditions.run --noexec
  Verifying archive integrity...  100%   MD5 checksums are OK. All good.
  Uncompressing VirtualBox 7.2.2 Guest Additions for Linux  100%

  I was sure this was due to the switchover of the waste-of-time
  coreutils rust rewrite (please ignore the editorial comment!)... but
  copying over coreutuils md5sum from 25.04 does not eliminate the
  error.

  Tar on both systems is 1.35.

  md5sum on today's (23 Sep) 25.10 reports: md5sum (uutils coreutils) 0.1.0
  on 25.04 where there's no failure it's: md5sum (GNU coreutils) 9.5
  but as noted, that exact binary moved to 25.10 to replace /usr/bin/md5sum does not improve matters there.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-release-notes/+bug/2125535/+subscriptions