[Bug 2138406] Re: rustc-1.85 FTBFS: Unknown compiletest directive

[Launchpad Bug Tracker]

** Merge proposal linked:
   https://code.launchpad.net/~maxgmr/ubuntu/+source/rustc-1.85/+git/rustc-1.85/+merge/498512

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to rustc-1.85 in Ubuntu.
https://bugs.launchpad.net/bugs/2138406

Title:
  rustc-1.85 FTBFS: Unknown compiletest directive

Status in rustc-1.85 package in Ubuntu:
  In Progress
Status in rustc-1.85 source package in Questing:
  In Progress
Status in rustc-1.85 source package in Resolute:
  In Progress

Bug description:
  [ Impact ]

   * In rustc-1.85, compiletest is failing due to the unknown 'ignore-hurd'
     test directive:

     error: detected unknown compiletest test directive `ignore-hurd` in /<<PKGBUILDDIR>>/tests/crashes/115994.rs:3
     errors encountered during EarlyProps parsing: /<<PKGBUILDDIR>>/tests/crashes/115994.rs

     thread 'main' panicked at src/tools/compiletest/src/header.rs:68:13:
     errors encountered during EarlyProps parsing
     stack backtrace:
        0: rust_begin_unwind
                  at ./library/std/src/panicking.rs:692:5
        1: core::panicking::panic_fmt
                  at ./library/core/src/panicking.rs:75:14
        2: <compiletest::header::EarlyProps>::from_file
        3: compiletest::make_test
        4: compiletest::collect_tests_from_dir
        5: compiletest::collect_and_make_tests
        6: compiletest::run_tests
        7: compiletest::main

   * This bug is caused by the d/p/upstream/u-hurd-tests.patch, a patch
     inherited from Debian which prevented tests which broke GNU Hurd
     platforms.

   * The extra test failures caused by this bug is causing i386 builds
     to fail on Resolute and Questing.

  [ Test Plan ]

   * Currently, builds will report the following two errors when running
     stage 2 "ui" and "crashes" compiletests respectively:
     - error: detected unknown compiletest test directive `ignore-hurd` in /<<PKGBUILDDIR>>/tests/ui/threads-sendsync/mpsc_stress.rs:4
     - error: detected unknown compiletest test directive `ignore-hurd` in /<<PKGBUILDDIR>>/tests/crashes/115994.rs:3

   * If the bug is fixed, then the buildlogs of the fixed rustc-1.85
     package should not contain the phrase "error: detected unknown
     compiletest test directive".

  [ Where problems could occur ]

   * First of all, this change only impacts the test files run during
     the build process, so it's unlikely to affect the package itself.

   * Second, since Ubuntu doesn't support GNU Hurd in the first place,
     the removed changes are unlikely to affect the upstream tests.

   * However, there is a potential that fixing this impacts the build
     process down the line. Since the unknown compiletest directives
     end the "ui" and "crashes" test suites early, the other tests
     weren't being run. If any of *those other* tests fail, then the
     build as a whole will still fail.

  [ Other Info ]

   * N/A

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rustc-1.85/+bug/2138406/+subscriptions