[Bug 2130973] Re: Sudo-rs panics executing shell script without execute permission

[Skia]

Ack, it's fine, uploaded:

$ dput ubuntu ../rust-sudo-rs_0.2.8-1ubuntu5.3_source.changes
Uploading rust-sudo-rs using ftp to ubuntu (host: upload.ubuntu.com; directory: /ubuntu)
running suite-mismatch: check the target distribution for common errors
running releasemismatch: Warn about mismatching suffixesg e.g. focal with a XX.YY not being 20.04
running placeholderbug: Stop if using common placeholder numbers as bug reference.
running updatemaintainer: Stop if ubuntu changes are without ubuntu maintainer.
running gpg: check GnuPG signatures before the upload
running supported-distribution: check whether the target distribution is currently supported (using distro-info)
{'allowed': ['release', 'proposed', 'backports', 'security'], 'known': ['release', 'proposed', 'updates', 'backports', 'security']}
running required-fields: check whether a field is present and non-empty in the changes file
running ppaforppaonly: Stop uploads to the archive with or to ppa without ~ppa suffix.
running checksum: verify checksums before uploading
running badauthor: Stop if uploading with root@ or ubuntu@ email adresses.
running check-debs: makes sure the upload contains a binary package
running gitubuntu: Warn if uploading without git-ubuntu Vcs-* entries.
running nobug: Stop if uploading without any bug reference.
Uploading rust-sudo-rs_0.2.8-1ubuntu5.3.dsc
Uploading rust-sudo-rs_0.2.8.orig-rust-vendor.tar.xz
Uploading rust-sudo-rs_0.2.8.orig.tar.gz
Uploading rust-sudo-rs_0.2.8-1ubuntu5.3.debian.tar.xz
Uploading rust-sudo-rs_0.2.8-1ubuntu5.3_source.buildinfo
Uploading rust-sudo-rs_0.2.8-1ubuntu5.3_source.changes

Now as soon as the SRU approves the package and you have it built in
-proposed, please remember to come and verify it, and/or have someone
else do some verification, so that it doesn't rot in -proposed.

Thanks for working on fixing bugs :-)

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to rust-sudo-rs in Ubuntu.
https://bugs.launchpad.net/bugs/2130973

Title:
  Sudo-rs panics executing shell script without execute permission

Status in rust-sudo-rs package in Ubuntu:
  Confirmed
Status in rust-sudo-rs source package in Questing:
  New

Bug description:
  Thank you @platform34 for the original description!

  [Impact]
  Currently running sudo-rs on a script with no execute permissions will lead to a crash of the program. This harms scripts which might expect only a permission denied error and handle them gracefully if they arise. The fix has been made available upstream here: https://github.com/trifectatechfoundation/sudo-rs/commit/eeb1ad77237353cbdf53772ca5278cd1dd1aed1b

  Ubuntu 26.04 already has the fix but 25.10 is affected.

  [Test Plan]
  1. Create a new file and make sure it has no execute permissions:
  $ touch test.sh
  $ ls -l test.sh
  -rw-rw-r-- 1 ghadi ghadi 0 Jan  9 18:41 test.sh

  2. Run sudo on the file while using sudo-rs and the following error
  will be shown:

  $ sudo ./test.sh                                    
  [sudo: authenticate] Password: 

  thread 'main' panicked at src/exec/use_pty/monitor.rs:283:45:
  internal error: entered unreachable code
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
  sudo-rs: cannot execute '/path/to/test.sh': Permission denied (os error 13)

  
  The expected behavior is the following output:
  $ sudo ./test.sh 
  sudo-rs: cannot execute '/path/to/test.sh': Permission denied (os error 13)

  Where only the permission denied error is printed and sudo does not
  panic.

  
  [ Where problems could occur ]

  * Since the changes touch on how error messages are sent in sudo-rs,
  it is possible that it might block some errors from properly
  propagating.

  
  [original description]
  My Ubuntu Budgie install was updated to Ubuntu 25.10 last week which replaced sudo with the rust sudo-rs version 0.2.8.

  Today I was executing a bash script with sudo and forgot to grant the
  script execute permission. Not a big problem however the response from
  sudo-rs was a panic, rather than a gracefully handled error message.

  I retested with a very simple script and the panic is 100%
  reproducible.

  Is this the same bug as:
  https://github.com/trifectatechfoundation/sudo-rs/pull/1298

  sudo ./test

  #!/bin/bash
  sudo apt update

  thread ‘main’ panicked at src/exec/use_pty/monitor.rs:283:45:
  internal error: entered unreachable code
  note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
  sudo-rs: cannot execute ‘/home/REDACTED/test’: Permission denied (os error 13)

  ProblemType: Bug
  DistroRelease: Ubuntu 25.10
  Package: sudo-rs 0.2.8-1ubuntu5
  ProcVersionSignature: Ubuntu 6.17.0-6.6-generic 6.17.1
  Uname: Linux 6.17.0-6-generic x86_64
  ApportVersion: 2.33.1-0ubuntu3
  Architecture: amd64
  CasperMD5CheckResult: pass
  CurrentDesktop: Budgie
  Date: Sun Nov  9 09:25:14 2025
  InstallationDate: Installed on 2025-10-23 (17 days ago)
  InstallationMedia: Ubuntu-Budgie 25.04 "Plucky Puffin" - Release amd64 (20250415.2)
  ProcEnviron:
   LANG=en_GB.UTF-8
   PATH=(custom, no user)
   SHELL=/bin/bash
   TERM=xterm-256color
   XDG_RUNTIME_DIR=<set>
  SourcePackage: rust-sudo-rs
  UpgradeStatus: Upgraded to questing on 2025-11-02 (7 days ago)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rust-sudo-rs/+bug/2130973/+subscriptions