[Bug 2097621] Re: Changing partition format requires a wipe value - when marking new partition as "Leave unformatted" or changing format

[Olivier Gayot]

** Changed in: subiquity
       Status: In Progress => Fix Committed

** Also affects: subiquity (Ubuntu)
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to subiquity in Ubuntu.
https://bugs.launchpad.net/bugs/2097621

Title:
  Changing partition format requires a wipe value - when marking new
  partition as "Leave unformatted" or changing format

Status in subiquity:
  Fix Committed
Status in ubuntu-desktop-provision:
  New
Status in subiquity package in Ubuntu:
  New

Bug description:
  When creating a partition and then changing it to make it
  "unformatted", the desktop installer crashes.

  Steps to reproduce
  ------------------

  * Boot the desktop installer ISO
  * Navigate to the Manual partitioning screen
  * Create a new partition in free space and give it a Ext4 filesystem (the default)
  * Select the new partition and click "Change"
  * Change "Used as" from "Ext4" to "Leave unformatted" and press OK
  * The installer crashes and the logs show the following error:

  > ValueError: changing partition format requires a wipe value

  When changing the format of a partition, the storage v2 API expects a
  wipe value to be specified (!= null).  While the desktop installer
  could specify a wipe value when moving from ext4 to no FS, it feels
  wrong to require a wipe value when the partition in question hasn't
  yet been created. At this point it was only staged for creation ; so
  there is nothing to wipe.

  I suggest we relax this requirement in the API, meaning we don't
  enforce a wipe value when the target partition does not "physically"
  exist yet.

To manage notifications about this bug go to:
https://bugs.launchpad.net/subiquity/+bug/2097621/+subscriptions