[PATCH] checksum-0001: fix tests to ignore RSDP
Keng-Yu Lin
kengyu at canonical.com
Mon Apr 23 04:25:16 UTC 2012
On Fri, Apr 20, 2012 at 6:47 PM, Colin King <colin.king at canonical.com> wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Due to the way we need to fixup (or create) some ACPI tables when mmap'ing them into
> low 32 bit memory for the ACPICA core we also had to re-calculate the table checksums
> which makes the checksum tests now fail.
>
> So, forget checking RSDP as this is the table that is getting fixed up and hence getting
> different checksums each time we run.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
> checksum-0001/checksum-0001.log | 14 +--
> checksum-0001/checksum-0003.log | 25 ++---
> checksum-0001/checksum-0004.log | 217 ++++++++++++++++++---------------------
> checksum-0001/test-0001.sh | 3 +-
> checksum-0001/test-0003.sh | 2 +-
> checksum-0001/test-0004.sh | 4 +-
> 6 files changed, 119 insertions(+), 146 deletions(-)
>
> diff --git a/checksum-0001/checksum-0001.log b/checksum-0001/checksum-0001.log
> index 2f500f8..35adf16 100644
> --- a/checksum-0001/checksum-0001.log
> +++ b/checksum-0001/checksum-0001.log
> @@ -1,5 +1,5 @@
> checksum Check ACPI table checksum.
> -checksum ---------------------------------------------------------
> +checksum -------------------------------------------------------------------------------------------------
> checksum Test 1 of 1: Check ACPI table checksums.
> checksum PASSED: Test 1, Table DSDT has correct checksum 0x11.
> checksum PASSED: Test 1, Table FACP has correct checksum 0x52.
> @@ -17,12 +17,8 @@ checksum PASSED: Test 1, Table SSDT has correct checksum 0xc8.
> checksum PASSED: Test 1, Table SSDT has correct checksum 0x6d.
> checksum PASSED: Test 1, Table SSDT has correct checksum 0xdf.
> checksum PASSED: Test 1, Table XSDT has correct checksum 0xc2.
> -checksum PASSED: Test 1, Table RSDP has correct checksum 0xc5.
> -checksum PASSED: Test 1, Table RSDP has correct extended checksum
> -checksum 0x39.
> -checksum PASSED: Test 1, Table RSDT has correct checksum 0x48.
> +checksum PASSED: Test 1, Table RSDT has correct checksum 0xd.
> checksum
> -checksum =========================================================
> -checksum 19 passed, 0 failed, 0 warnings, 0 aborted, 0 skipped, 0
> -checksum info only.
> -checksum =========================================================
> +checksum =================================================================================================
> +checksum 19 passed, 0 failed, 0 warnings, 0 aborted, 0 skipped, 0 info only.
> +checksum =================================================================================================
> diff --git a/checksum-0001/checksum-0003.log b/checksum-0001/checksum-0003.log
> index 3ef8877..e90cf44 100644
> --- a/checksum-0001/checksum-0003.log
> +++ b/checksum-0001/checksum-0003.log
> @@ -1,13 +1,12 @@
> checksum Check ACPI table checksum.
> -checksum ---------------------------------------------------------
> +checksum -------------------------------------------------------------------------------------------------
> checksum Test 1 of 1: Check ACPI table checksums.
> -checksum FAILED [LOW] ACPITableChecksum: Test 1, Table DSDT has
> -checksum incorrect checksum, expected 0x11, got 0x10.
> +checksum FAILED [LOW] ACPITableChecksum: Test 1, Table DSDT has incorrect checksum, expected 0x11, got
> +checksum 0x10.
> checksum
> -checksum ADVICE: The kernel will warn that this table has an
> -checksum invalid checksum but will ignore the error and still load
> -checksum it. This is not a critical issue, but should be fixed if
> -checksum possible to avoid the warning messages.
> +checksum ADVICE: The kernel will warn that this table has an invalid checksum but will ignore the error and
> +checksum still load it. This is not a critical issue, but should be fixed if possible to avoid the warning
> +checksum messages.
> checksum
> checksum PASSED: Test 1, Table FACP has correct checksum 0x52.
> checksum PASSED: Test 1, Table APIC has correct checksum 0xcc.
> @@ -24,12 +23,8 @@ checksum PASSED: Test 1, Table SSDT has correct checksum 0xc8.
> checksum PASSED: Test 1, Table SSDT has correct checksum 0x6d.
> checksum PASSED: Test 1, Table SSDT has correct checksum 0xdf.
> checksum PASSED: Test 1, Table XSDT has correct checksum 0xc2.
> -checksum PASSED: Test 1, Table RSDP has correct checksum 0xc5.
> -checksum PASSED: Test 1, Table RSDP has correct extended checksum
> -checksum 0x39.
> -checksum PASSED: Test 1, Table RSDT has correct checksum 0x48.
> +checksum PASSED: Test 1, Table RSDT has correct checksum 0xd.
> checksum
> -checksum =========================================================
> -checksum 18 passed, 1 failed, 0 warnings, 0 aborted, 0 skipped, 0
> -checksum info only.
> -checksum =========================================================
> +checksum =================================================================================================
> +checksum 18 passed, 1 failed, 0 warnings, 0 aborted, 0 skipped, 0 info only.
> +checksum =================================================================================================
> diff --git a/checksum-0001/checksum-0004.log b/checksum-0001/checksum-0004.log
> index 0ad6cc7..775d04c 100644
> --- a/checksum-0001/checksum-0004.log
> +++ b/checksum-0001/checksum-0004.log
> @@ -1,132 +1,113 @@
> checksum Check ACPI table checksum.
> -checksum ---------------------------------------------------------
> +checksum -------------------------------------------------------------------------------------------------
> checksum Test 1 of 1: Check ACPI table checksums.
> checksum PASSED: Test 1, Table DSDT has correct checksum 0x11.
> -checksum FAILED [LOW] ACPITableChecksum: Test 1, Table FACP has
> -checksum incorrect checksum, expected 0x52, got 0x53.
> +checksum FAILED [LOW] ACPITableChecksum: Test 1, Table FACP has incorrect checksum, expected 0x52, got
> +checksum 0x53.
> checksum
> -checksum ADVICE: The kernel will warn that this table has an
> -checksum invalid checksum but will ignore the error and still load
> -checksum it. This is not a critical issue, but should be fixed if
> -checksum possible to avoid the warning messages.
> +checksum ADVICE: The kernel will warn that this table has an invalid checksum but will ignore the error and
> +checksum still load it. This is not a critical issue, but should be fixed if possible to avoid the warning
> +checksum messages.
> checksum
> -checksum FAILED [LOW] ACPITableChecksum: Test 1, Table APIC has
> -checksum incorrect checksum, expected 0xcc, got 0xcb.
> +checksum FAILED [LOW] ACPITableChecksum: Test 1, Table APIC has incorrect checksum, expected 0xcc, got
> +checksum 0xcb.
> checksum
> -checksum ADVICE: The kernel will warn that this table has an
> -checksum invalid checksum but will ignore the error and still load
> -checksum it. This is not a critical issue, but should be fixed if
> -checksum possible to avoid the warning messages.
> +checksum ADVICE: The kernel will warn that this table has an invalid checksum but will ignore the error and
> +checksum still load it. This is not a critical issue, but should be fixed if possible to avoid the warning
> +checksum messages.
> checksum
> -checksum FAILED [LOW] ACPITableChecksum: Test 1, Table HPET has
> -checksum incorrect checksum, expected 0x0a, got 0x09.
> +checksum FAILED [LOW] ACPITableChecksum: Test 1, Table HPET has incorrect checksum, expected 0x0a, got
> +checksum 0x09.
> checksum
> -checksum ADVICE: The kernel will warn that this table has an
> -checksum invalid checksum but will ignore the error and still load
> -checksum it. This is not a critical issue, but should be fixed if
> -checksum possible to avoid the warning messages.
> +checksum ADVICE: The kernel will warn that this table has an invalid checksum but will ignore the error and
> +checksum still load it. This is not a critical issue, but should be fixed if possible to avoid the warning
> +checksum messages.
> checksum
> -checksum FAILED [LOW] ACPITableChecksum: Test 1, Table MCFG has
> -checksum incorrect checksum, expected 0x32, got 0x33.
> +checksum FAILED [LOW] ACPITableChecksum: Test 1, Table MCFG has incorrect checksum, expected 0x32, got
> +checksum 0x33.
> checksum
> -checksum ADVICE: The kernel will warn that this table has an
> -checksum invalid checksum but will ignore the error and still load
> -checksum it. This is not a critical issue, but should be fixed if
> -checksum possible to avoid the warning messages.
> -checksum
> -checksum FAILED [LOW] ACPITableChecksum: Test 1, Table TCPA has
> -checksum incorrect checksum, expected 0x8f, got 0xff.
> -checksum
> -checksum ADVICE: The kernel will warn that this table has an
> -checksum invalid checksum but will ignore the error and still load
> -checksum it. This is not a critical issue, but should be fixed if
> -checksum possible to avoid the warning messages.
> -checksum
> -checksum FAILED [LOW] ACPITableChecksum: Test 1, Table TMOR has
> -checksum incorrect checksum, expected 0xeb, got 0xbe.
> -checksum
> -checksum ADVICE: The kernel will warn that this table has an
> -checksum invalid checksum but will ignore the error and still load
> -checksum it. This is not a critical issue, but should be fixed if
> -checksum possible to avoid the warning messages.
> -checksum
> -checksum FAILED [LOW] ACPITableChecksum: Test 1, Table SLIC has
> -checksum incorrect checksum, expected 0x99, got 0x88.
> -checksum
> -checksum ADVICE: The kernel will warn that this table has an
> -checksum invalid checksum but will ignore the error and still load
> -checksum it. This is not a critical issue, but should be fixed if
> -checksum possible to avoid the warning messages.
> -checksum
> -checksum FAILED [LOW] ACPITableChecksum: Test 1, Table APIC has
> -checksum incorrect checksum, expected 0x13, got 0x12.
> -checksum
> -checksum ADVICE: The kernel will warn that this table has an
> -checksum invalid checksum but will ignore the error and still load
> -checksum it. This is not a critical issue, but should be fixed if
> -checksum possible to avoid the warning messages.
> -checksum
> -checksum FAILED [LOW] ACPITableChecksum: Test 1, Table BOOT has
> -checksum incorrect checksum, expected 0xa5, got 0xa6.
> -checksum
> -checksum ADVICE: The kernel will warn that this table has an
> -checksum invalid checksum but will ignore the error and still load
> -checksum it. This is not a critical issue, but should be fixed if
> -checksum possible to avoid the warning messages.
> -checksum
> -checksum FAILED [LOW] ACPITableChecksum: Test 1, Table SSDT has
> -checksum incorrect checksum, expected 0x59, got 0x01.
> -checksum
> -checksum ADVICE: The kernel will warn that this table has an
> -checksum invalid checksum but will ignore the error and still load
> -checksum it. This is not a critical issue, but should be fixed if
> -checksum possible to avoid the warning messages.
> -checksum
> -checksum FAILED [LOW] ACPITableChecksum: Test 1, Table SSDT has
> -checksum incorrect checksum, expected 0xed, got 0xef.
> -checksum
> -checksum ADVICE: The kernel will warn that this table has an
> -checksum invalid checksum but will ignore the error and still load
> -checksum it. This is not a critical issue, but should be fixed if
> -checksum possible to avoid the warning messages.
> -checksum
> -checksum FAILED [LOW] ACPITableChecksum: Test 1, Table SSDT has
> -checksum incorrect checksum, expected 0xc8, got 0x00.
> -checksum
> -checksum ADVICE: The kernel will warn that this table has an
> -checksum invalid checksum but will ignore the error and still load
> -checksum it. This is not a critical issue, but should be fixed if
> -checksum possible to avoid the warning messages.
> -checksum
> -checksum FAILED [LOW] ACPITableChecksum: Test 1, Table SSDT has
> -checksum incorrect checksum, expected 0x6d, got 0xdd.
> -checksum
> -checksum ADVICE: The kernel will warn that this table has an
> -checksum invalid checksum but will ignore the error and still load
> -checksum it. This is not a critical issue, but should be fixed if
> -checksum possible to avoid the warning messages.
> -checksum
> -checksum FAILED [LOW] ACPITableChecksum: Test 1, Table SSDT has
> -checksum incorrect checksum, expected 0xdf, got 0xde.
> +checksum ADVICE: The kernel will warn that this table has an invalid checksum but will ignore the error and
> +checksum still load it. This is not a critical issue, but should be fixed if possible to avoid the warning
> +checksum messages.
> checksum
> -checksum ADVICE: The kernel will warn that this table has an
> -checksum invalid checksum but will ignore the error and still load
> -checksum it. This is not a critical issue, but should be fixed if
> -checksum possible to avoid the warning messages.
> -checksum
> -checksum FAILED [CRITICAL] ACPITableChecksum: Test 1, Table XSDT
> -checksum has incorrect checksum, expected 0xc2, got 0xc3.
> +checksum FAILED [LOW] ACPITableChecksum: Test 1, Table TCPA has incorrect checksum, expected 0x8f, got
> +checksum 0xff.
> checksum
> -checksum ADVICE: The kernel requires this table to have a valid
> -checksum checksum and will not load it. This will lead to ACPI not
> -checksum working correctly.
> +checksum ADVICE: The kernel will warn that this table has an invalid checksum but will ignore the error and
> +checksum still load it. This is not a critical issue, but should be fixed if possible to avoid the warning
> +checksum messages.
> checksum
> -checksum PASSED: Test 1, Table RSDP has correct checksum 0xc5.
> -checksum PASSED: Test 1, Table RSDP has correct extended checksum
> -checksum 0x39.
> -checksum PASSED: Test 1, Table RSDT has correct checksum 0x48.
> +checksum FAILED [LOW] ACPITableChecksum: Test 1, Table TMOR has incorrect checksum, expected 0xeb, got
> +checksum 0xbe.
> checksum
> -checksum =========================================================
> -checksum 4 passed, 15 failed, 0 warnings, 0 aborted, 0 skipped, 0
> -checksum info only.
> -checksum =========================================================
> +checksum ADVICE: The kernel will warn that this table has an invalid checksum but will ignore the error and
> +checksum still load it. This is not a critical issue, but should be fixed if possible to avoid the warning
> +checksum messages.
> +checksum
> +checksum FAILED [LOW] ACPITableChecksum: Test 1, Table SLIC has incorrect checksum, expected 0x99, got
> +checksum 0x88.
> +checksum
> +checksum ADVICE: The kernel will warn that this table has an invalid checksum but will ignore the error and
> +checksum still load it. This is not a critical issue, but should be fixed if possible to avoid the warning
> +checksum messages.
> +checksum
> +checksum FAILED [LOW] ACPITableChecksum: Test 1, Table APIC has incorrect checksum, expected 0x13, got
> +checksum 0x12.
> +checksum
> +checksum ADVICE: The kernel will warn that this table has an invalid checksum but will ignore the error and
> +checksum still load it. This is not a critical issue, but should be fixed if possible to avoid the warning
> +checksum messages.
> +checksum
> +checksum FAILED [LOW] ACPITableChecksum: Test 1, Table BOOT has incorrect checksum, expected 0xa5, got
> +checksum 0xa6.
> +checksum
> +checksum ADVICE: The kernel will warn that this table has an invalid checksum but will ignore the error and
> +checksum still load it. This is not a critical issue, but should be fixed if possible to avoid the warning
> +checksum messages.
> +checksum
> +checksum FAILED [LOW] ACPITableChecksum: Test 1, Table SSDT has incorrect checksum, expected 0x59, got
> +checksum 0x01.
> +checksum
> +checksum ADVICE: The kernel will warn that this table has an invalid checksum but will ignore the error and
> +checksum still load it. This is not a critical issue, but should be fixed if possible to avoid the warning
> +checksum messages.
> +checksum
> +checksum FAILED [LOW] ACPITableChecksum: Test 1, Table SSDT has incorrect checksum, expected 0xed, got
> +checksum 0xef.
> +checksum
> +checksum ADVICE: The kernel will warn that this table has an invalid checksum but will ignore the error and
> +checksum still load it. This is not a critical issue, but should be fixed if possible to avoid the warning
> +checksum messages.
> +checksum
> +checksum FAILED [LOW] ACPITableChecksum: Test 1, Table SSDT has incorrect checksum, expected 0xc8, got
> +checksum 0x00.
> +checksum
> +checksum ADVICE: The kernel will warn that this table has an invalid checksum but will ignore the error and
> +checksum still load it. This is not a critical issue, but should be fixed if possible to avoid the warning
> +checksum messages.
> +checksum
> +checksum FAILED [LOW] ACPITableChecksum: Test 1, Table SSDT has incorrect checksum, expected 0x6d, got
> +checksum 0xdd.
> +checksum
> +checksum ADVICE: The kernel will warn that this table has an invalid checksum but will ignore the error and
> +checksum still load it. This is not a critical issue, but should be fixed if possible to avoid the warning
> +checksum messages.
> +checksum
> +checksum FAILED [LOW] ACPITableChecksum: Test 1, Table SSDT has incorrect checksum, expected 0xdf, got
> +checksum 0xde.
> +checksum
> +checksum ADVICE: The kernel will warn that this table has an invalid checksum but will ignore the error and
> +checksum still load it. This is not a critical issue, but should be fixed if possible to avoid the warning
> +checksum messages.
> +checksum
> +checksum FAILED [CRITICAL] ACPITableChecksum: Test 1, Table XSDT has incorrect checksum, expected 0xc2, got
> +checksum 0xc3.
> +checksum
> +checksum ADVICE: The kernel requires this table to have a valid checksum and will not load it. This will
> +checksum lead to ACPI not working correctly.
> +checksum
> +checksum PASSED: Test 1, Table RSDT has correct checksum 0xd.
> +checksum
> +checksum =================================================================================================
> +checksum 4 passed, 15 failed, 0 warnings, 0 aborted, 0 skipped, 0 info only.
> +checksum =================================================================================================
> diff --git a/checksum-0001/test-0001.sh b/checksum-0001/test-0001.sh
> index 1a1cde3..839e136 100755
> --- a/checksum-0001/test-0001.sh
> +++ b/checksum-0001/test-0001.sh
> @@ -4,8 +4,9 @@ TEST="Test checksum against known correct ACPI tables"
> NAME=test-0001.sh
> TMPLOG=$TMP/checksum.log.$$
>
> -$FWTS -w 80 --dumpfile=acpidump-0001.log checksum - | grep "^[0-9]*[ ]*checksum" | cut -c7- > $TMPLOG
> +$FWTS -w 120 --dumpfile=acpidump-0001.log checksum - | grep "^[0-9]*[ ]*checksum" | grep -v RSDP | cut -c7- > $TMPLOG
> diff $TMPLOG checksum-0001.log >> $FAILURE_LOG
> +cp $TMPLOG checksum-0001.log
> ret=$?
> if [ $ret -eq 0 ]; then
> echo PASSED: $TEST, $NAME
> diff --git a/checksum-0001/test-0003.sh b/checksum-0001/test-0003.sh
> index cb168bc..42c5a45 100755
> --- a/checksum-0001/test-0003.sh
> +++ b/checksum-0001/test-0003.sh
> @@ -4,7 +4,7 @@ TEST="Test checksum against incorrect ACPI DSDT table"
> NAME=test-0003.sh
> TMPLOG=$TMP/checksum.log.$$
>
> -$FWTS -w 80 --dumpfile=acpidump-0003.log checksum - | grep "^[0-9]*[ ]*checksum" | cut -c7- > $TMPLOG
> +$FWTS -w 120 --dumpfile=acpidump-0003.log checksum - | grep "^[0-9]*[ ]*checksum" | grep -v RSDP | cut -c7- > $TMPLOG
> diff $TMPLOG checksum-0003.log >> $FAILURE_LOG
> ret=$?
> if [ $ret -eq 0 ]; then
> diff --git a/checksum-0001/test-0004.sh b/checksum-0001/test-0004.sh
> index bf88e83..c45e1f3 100755
> --- a/checksum-0001/test-0004.sh
> +++ b/checksum-0001/test-0004.sh
> @@ -4,10 +4,10 @@ TEST="Test checksum against incorrect ACPI DSDT table"
> NAME=test-0004.sh
> TMPLOG=$TMP/checksum.log.$$
>
> -$FWTS -w 80 --dumpfile=acpidump-0004.log checksum - | grep "^[0-9]*[ ]*checksum" | cut -c7- > $TMPLOG
> +$FWTS -w 120 --dumpfile=acpidump-0004.log checksum - | grep "^[0-9]*[ ]*checksum" | grep -v RSDP | cut -c7- > $TMPLOG
> diff $TMPLOG checksum-0004.log >> $FAILURE_LOG
> ret=$?
> -if [ $? -eq 0 ]; then
> +if [ $ret -eq 0 ]; then
> echo PASSED: $TEST, $NAME
> else
> echo FAILED: $TEST, $NAME
> --
> 1.7.9.5
>
Acked-by: Keng-Yu Lin <kengyu at canonical.com>
More information about the fwts-devel
mailing list