[PATCH] data: klog.json: Add more specfic parse/execution failure checks on timeouts

Colin King colin.king at canonical.com
Mon Dec 17 11:46:09 UTC 2012


From: Colin Ian King <colin.king at canonical.com>

Some ACPI parse/execution failure error messages from the kernel are caused
by device timeouts, so handle the specific EC timeout error and also the more
generic device timeout errors.

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 data/klog.json | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/data/klog.json b/data/klog.json
index adb0014..00c44e7 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -2723,11 +2723,27 @@
    "label": "KlogAcpiMethodNoReturnValue"
   },
   {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
+   "pattern": "Method parse/execution failed.*EC.*AE_TIME",
+   "advice": "The ACPI driver encounted an error executing some ACPI AML code which originated from the Embedded Controller (EC) timing out while waiting for a transaction to complete. This could indicate that either EC interrupts are being disabled or that the EC has temporarily gone offline or locked up, so this could be a kernel error or more probably a bug in the EC firmware.  See the kernel driver drivers/acpi/ec.c.  One can increase EC timeouts using the kernel parameter ec_delay to specify the timeout in milliseconds, the default is 500.",
+   "label": "KlogAcpiEcTimeout"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
+   "pattern": "Method parse/execution failed.*AE_TIME",
+   "advice": "The ACPI driver encounted an error executing some ACPI AML code which originated from a device timing out.",
+   "label": "KlogAcpiTimeout"
+  },
+  {
    "compare_mode": "string",
    "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
    "pattern": "Method parse/execution failed",
-   "advice": "The ACPI driver encounter a parse or execution error on some ACPI AML code. This is unexepcted and normally indicates that there is a bug in the compiled AML code.  It could be a programming fault or an AML compiler issue.  See acpi_ps_parse_aml().",
+   "advice": "The ACPI driver encounted a parse or execution error on some ACPI AML code. This is unexepcted and normally indicates that there is a bug in the compiled AML code.  It could be a programming fault or an AML compiler issue.  See acpi_ps_parse_aml().",
    "label": "KlogAcpiParseExecAmlFailed"
   },
   {
-- 
1.8.0




More information about the fwts-devel mailing list