[PATCH] acpi: method: don't bother reporting internal ACPI lock success

IvanHu ivan.hu at canonical.com
Thu Dec 20 02:29:12 UTC 2012


On 12/13/2012 02:35 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Each object that gets evaluated has a sanity check to see if the
> internal locking state is sane.  This rarely goes wrong, so ingore
> reporting success as this adds to the noise on the output. Just report
> failures.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/acpi/method/method.c | 10 ++--------
>   1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 3ec7836..52b0e18 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -342,8 +342,7 @@ static void method_evaluate_found_method(
>
>   	if (ACPI_FAILURE(ret) != AE_OK) {
>   		fwts_method_evaluate_report_error(fw, name, ret);
> -	}
> -	else {
> +	} else {
>   		if (check_func != NULL) {
>   			ACPI_OBJECT *obj = buf.Pointer;
>   			check_func(fw, name, &buf, obj, private);
> @@ -366,12 +365,7 @@ static void method_evaluate_found_method(
>   			"acquired lock. It may be occurring in the method "
>   			"being tested or other methods used while evaluating "
>   			"the method.");
> -	} else
> -		if ((sem_acquired + sem_released) > 0)
> -			fwts_passed(fw,
> -				"%s correctly acquired and released locks "
> -				"%d times.", name, sem_acquired);
> -
> +	}
>   }
>
>   /*
>
Acked-by: Ivan Hu <ivan.hu at canonical.com>



More information about the fwts-devel mailing list