[PATCH 2/2] acpi: method: remove race delay kludge

IvanHu ivan.hu at canonical.com
Wed Jul 18 02:12:13 UTC 2012


On 07/17/2012 02:09 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Since we've fixed the semaphore count race we should remove
> this race delay kludge.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/acpi/method/method.c |    8 --------
>   1 file changed, 8 deletions(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index a4ccd3a..fe3aad1 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -28,9 +28,6 @@
>   #include "acpi.h"
>   #include "fwts_acpi_method.h"
>
> -/* Add small delay between each test */
> -#define METHOD_DELAY_USECS	(0)
> -
>   /*
>    * ACPI methods + objects used in Linux ACPI driver:
>    *
> @@ -325,11 +322,6 @@ static void method_evaluate_found_method(fwts_framework *fw, char *name,
>   	if (buf.Length && buf.Pointer)
>   		free(buf.Pointer);
>
> -#if METHOD_DELAY_USECS
> -	/* Seen ACPICA core not release locks quickly, so put a delay in. Urgh. */
> -	usleep(METHOD_DELAY_USECS);
> -#endif
> -
>   	fwts_acpica_sem_count_get(&sem_acquired, &sem_released);
>   	if (sem_acquired != sem_released) {
>   		fwts_failed(fw, LOG_LEVEL_MEDIUM, "AMLLocksAcquired",
>

Acked-by: Ivan Hu<ivan.hu at canonical.com>



More information about the fwts-devel mailing list