[PATCH 3/8] lib: fwts_guid.c: add more comments

IvanHu ivan.hu at canonical.com
Thu May 31 04:38:50 UTC 2012


On 05/25/2012 06:40 PM, Colin King wrote:
> From: Colin Ian King<colin.king at canonical.com>
>
> Signed-off-by: Colin Ian King<colin.king at canonical.com>
> ---
>   src/lib/src/fwts_guid.c |    5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/src/lib/src/fwts_guid.c b/src/lib/src/fwts_guid.c
> index 34dfd60..749591b 100644
> --- a/src/lib/src/fwts_guid.c
> +++ b/src/lib/src/fwts_guid.c
> @@ -21,6 +21,11 @@
>
>   #include "fwts.h"
>
> +/*
> + *  fwts_guid_buf_to_str()
> + *	format given GUID 'guid' into a string guid_str.
> + *	guid_str needs to be at least 37 chars long
> + */
>   void fwts_guid_buf_to_str(uint8_t *guid, char *guid_str, size_t guid_str_len)
>   {
>   	if (guid_str&&  guid_str_len>  36)

Hi Colin,

When I applied the patch, it occurred:

Applying: lib: fwts_guid.c: add more comments
/home/ivanhu/fwts/.git/rebase-apply/patch:15: trailing whitespace.
  *    format given GUID 'guid' into a string guid_str.
warning: 1 line adds whitespace errors.
It seems that there are a trailing whitespace in the comments. Should we 
remove this warning?


Best regards,
Ivan




More information about the fwts-devel mailing list