ACK: [PATCH] checksum-0001: fix diff return check

Alex Hung alex.hung at canonical.com
Fri Jul 12 02:31:44 UTC 2013


On 07/08/2013 11:56 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Commit 25e82837d8f01dd7928c435082d42e5086073345 introduced a bug
> in checking for the diff return. This appeared during some debugging
> I did and I somehow foolishly checked this in.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   checksum-0001/test-0001.sh | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/checksum-0001/test-0001.sh b/checksum-0001/test-0001.sh
> index 89aa14a..79dcd73 100755
> --- a/checksum-0001/test-0001.sh
> +++ b/checksum-0001/test-0001.sh
> @@ -6,9 +6,8 @@ TMPLOG=$TMP/checksum.log.$$
>
>   $FWTS --log-format="%line %owner " -w 120 --dumpfile=acpidump-0001.log checksum - | grep "^[0-9]*[ ]*checksum" | grep -v RSDP | cut -c7- > $TMPLOG
>   diff $TMPLOG checksum-0001.log >> $FAILURE_LOG
> -cp $TMPLOG checksum-0001.log
>   ret=$?
> -if [ $ret -eq 0 ]; then
> +if [ $ret -eq 0 ]; then
>   	echo PASSED: $TEST, $NAME
>   else
>   	echo FAILED: $TEST, $NAME
>

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list