[PATCH] acpi: syntaxcheck: use ASL_MESSAGE_TYPES instead of #defining them (LP: #1200568)

Colin King colin.king at canonical.com
Fri Jul 12 10:35:37 UTC 2013


From: Colin Ian King <colin.king at canonical.com>

The IASL error codes are hard coded in fwts syntaxcheck and now differ
from the ones in ACPICA, so we are no longer picking up errors.
Instead we should use the ACPCIA error codes as defined in aslmessages.h
which we are already #including by are subsequently redefining. So just
remove the dodgy #defines and it all works correctly.

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 src/acpi/syntaxcheck/syntaxcheck.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/src/acpi/syntaxcheck/syntaxcheck.c b/src/acpi/syntaxcheck/syntaxcheck.c
index 5d0ae6c..61d46f8 100644
--- a/src/acpi/syntaxcheck/syntaxcheck.c
+++ b/src/acpi/syntaxcheck/syntaxcheck.c
@@ -45,13 +45,6 @@ static void syntaxcheck_free_advice(void);
  */
 #define SYNTAXCHECK_JSON_FILE		"syntaxcheck.json"
 
-#define ASL_WARNING             0
-#define ASL_WARNING2            1
-#define ASL_WARNING3            2
-#define ASL_ERROR               3
-#define ASL_REMARK		4
-#define ASL_OPTIMIZATION	5
-
 #define ASL_ID(error)	{ error, #error, NULL }
 
 /*
-- 
1.8.1.2




More information about the fwts-devel mailing list