ACK: [PATCH] configure.ac: Use AM_PROG_AR when it exists

Colin Ian King colin.king at canonical.com
Mon Jun 3 10:33:40 UTC 2013


On 03/06/13 11:07, Keng-Yu Lin wrote:
> The new AM_PROG_AR macro was added in automake 1.11.2.
> automake warns on this. And because the -Werror flag is default in fwts,
> this breaks the Saucy build.
> 
> The patch just checks if the macro is defined. If so, just use it.
> 
> Signed-off-by: Keng-Yu Lin <kengyu at canonical.com>
> ---
>  configure.ac | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configure.ac b/configure.ac
> index 77d44bf..c0411c1 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1,5 +1,6 @@
>  	  AC_INIT([fwts],[0.1],[colin.king at canonical.com])
>            AM_INIT_AUTOMAKE([-Wall -Werror foreign])
> +          m4_ifdef([AM_PROG_AR], [AM_PROG_AR])
>  	  AC_CANONICAL_HOST
>  	  AC_CONFIG_MACRO_DIR([m4])
>            AC_PROG_CC
> 

Ack - the conditional is useful on older releases that don't have
AM_PROG_AR defined.

Acked-by: Colin Ian King <colin.king at canonical.com>





More information about the fwts-devel mailing list