ACK: [PATCH] s3: fix multiple s3 tests stop working (LP: #1359037)

Colin Ian King colin.king at canonical.com
Wed Aug 20 07:35:05 UTC 2014


On 20/08/14 06:39, Ivan Hu wrote:
> fwts s3 --s3-multiple=30 can only do twice or thrice, and then it stops working.
> 
> Signed-off-by: Ivan Hu <ivan.hu at canonical.com>
> ---
>  src/acpi/s3/s3.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/acpi/s3/s3.c b/src/acpi/s3/s3.c
> index 7ad4e5f..411d243 100644
> --- a/src/acpi/s3/s3.c
> +++ b/src/acpi/s3/s3.c
> @@ -456,7 +456,7 @@ static int s3_test_multiple(fwts_framework *fw)
>  			tv.tv_usec = (awake_delay % 1000)*1000;
>  			select(0, NULL, NULL, NULL, &tv);
>  
> -			for (j = 0; j < awake_delay / 1000; i++) {
> +			for (j = 0; j < awake_delay / 1000; j++) {
>  				snprintf(buffer, sizeof(buffer), "(Waiting %d/%d seconds)",
>  					j + 1, awake_delay / 1000);
>  				fwts_progress_message(fw, percent, buffer);
> 
Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the fwts-devel mailing list