[PATCH 0/3] ACPI: a missing FACS table can be ignored under some circumstances

Fu Wei fu.wei at linaro.org
Tue Dec 2 05:08:25 UTC 2014


ACPI: 
  improve the return values and the log info in the fwts_acpi_handle_fadt_tables function.
  add the hardware reduced mode check function in src/lib/src/fwts_acpi_tables.c.
  a missing FACS table can be ignored under some circumstances

Both of the FADT fields FIRMWARE_CTRL and X_FIRMWARE_CTRL are
allowed to be null, if and only if ACPI is operating in hardware-
reduced mode.  If the ACPI tables are from before ACPI 5.0, or if
ACPI is not operating in hardware-reduced mode, at least one of the
FIRMWARE_CTRL or X_FIRMWARE_CTRL fields _must_ be non-null.

This patch corrects the logic to ensure that a missing FACS is only
allowed under the proper circumstances.

 src/acpi/acpitables/acpitables.c   |  5 ++--
 src/lib/include/fwts_acpi.h        |  1 +
 src/lib/include/fwts_acpi_tables.h |  2 ++
 src/lib/src/fwts_acpi_tables.c     | 48 +++++++++++++++++++++++++++++---------
 4 files changed, 43 insertions(+), 13 deletions(-)

Signed-off-by: Fu Wei <fu.wei at linaro.org>
Acked-by: Hanjun Guo <hanjun.guo at linaro.org>
Reviewed-by: Al Stone <al.stone at linaro.org>
-- 
1.8.3.1



More information about the fwts-devel mailing list