[PATCH] acpi: s4: fix infinite loop because wrong variable being incremented

Colin King colin.king at canonical.com
Tue Dec 2 10:17:07 UTC 2014


From: Colin Ian King <colin.king at canonical.com>

Fix typo on variable being incremented which leads to a possible
infinite loop while waiting. Detected by Coverity Scan.

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 src/acpi/s4/s4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/acpi/s4/s4.c b/src/acpi/s4/s4.c
index 684cb68..90a6bfd 100644
--- a/src/acpi/s4/s4.c
+++ b/src/acpi/s4/s4.c
@@ -425,7 +425,7 @@ static int s4_test_multiple(fwts_framework *fw)
 			tv.tv_usec = (awake_delay % 1000)*1000;
 			select(0, NULL, NULL, NULL, &tv);
 
-			for (j = 0; j < awake_delay / 1000; i++) {
+			for (j = 0; j < awake_delay / 1000; j++) {
 				snprintf(buffer, sizeof(buffer), "(Waiting %d/%d seconds)",
 					j + 1, awake_delay / 1000);
 				fwts_progress_message(fw, percent, buffer);
-- 
2.1.3




More information about the fwts-devel mailing list