ACK: [PATCH][RESEND] data: klog.json: lower the level of the failure when the _S1 and _S2 not implemented (LP: #1279714)

[Colin Ian King]

On 14/02/14 06:49, Ivan Hu wrote:
> From: IvanHu <ivan.hu at canonical.com>
> 
> Many machines don't implement the sleep state objects _S1 and _S2 on their firmware
> due to these two sleep states are seldom used.
> And it will cause the fwts klog test high failure as below:
> 
> klog: HIGH Kernel message: [ 0.291430] ACPI Exception: AE_NOT_FOUND, While evaluating Sleep State [\_S1_] (20130517/hwxface-571)
> klog: HIGH Kernel message: [ 0.291435] ACPI Exception: AE_NOT_FOUND, While evaluating Sleep State [\_S2_] (20130517/hwxface-571)
> 
> Signed-off-by: Ivan Hu <ivan.hu at canonical.com>
> ---
>  data/klog.json |   14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/data/klog.json b/data/klog.json
> index da08962..936e1b3 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -1053,6 +1053,20 @@
>    },
>    {
>      "compare_mode": "string",
> +    "log_level": "LOG_LEVEL_INFO",
> +    "pattern": "While evaluating Sleep State [\\_S1_]",
> +    "advice": "The exception comes from kernel cannot find _S1 namespace object that contains the register values for the sleep state when kernel would like to setup all the sleep state information. This means kernel don't know how to enter S1 sleep state. But it should not be a problem if the S1 sleep state isn't supported intentionally.",
> +    "label": "KlogAcpiSleepStateEvalFailed"
> +  },
> +  {
> +    "compare_mode": "string",
> +    "log_level": "LOG_LEVEL_INFO",
> +    "pattern": "While evaluating Sleep State [\\_S2_]",
> +    "advice": "The exception comes from kernel cannot find _S2 namespace object that contains the register values for the sleep state when kernel would like to setup all the sleep state information. This means kernel don't know how to enter S2 sleep state. But it should not be a problem if the S2 sleep state isn't supported intentionally.",
> +    "label": "KlogAcpiSleepStateEvalFailed"
> +  },
> +  {
> +    "compare_mode": "string",
>      "log_level": "LOG_LEVEL_HIGH",
>      "pattern": "While evaluating Sleep State",
>      "advice": "Failed to evaluate _Sx namespace object that contains the register values for the sleep state.",
> 

Acked-by: Colin Ian King <colin.king at canonical.com>