[RFC,PATCH 5/7 v2] acpi: only run ACPI tests if we have ACPI
Jeremy Kerr
jk at ozlabs.org
Thu May 1 10:49:36 UTC 2014
Hi Colin,
>> src/acpi/acpitables/acpitables.c | 5 +++--
>> src/acpi/checksum/checksum.c | 5 +++--
>> src/acpi/method/method.c | 3 ++-
>> src/acpi/syntaxcheck/syntaxcheck.c | 3 ++-
>> src/pci/aspm/aspm.c | 5 +++--
>> 5 files changed, 13 insertions(+), 8 deletions(-)
>
> There are a bunch more ACPI related tests that probably need attention too:
Yep, I was going for an in-principal approval of the concept before
attacking more of the tests :)
>> diff --git a/src/acpi/acpitables/acpitables.c b/src/acpi/acpitables/acpitables.c
>> index 439df2a..5f6beb9 100644
>> --- a/src/acpi/acpitables/acpitables.c
>> +++ b/src/acpi/acpitables/acpitables.c
>> @@ -613,7 +613,8 @@ static fwts_framework_minor_test acpi_table_check_tests[] = {
>>
>> static fwts_framework_ops acpi_table_check_ops = {
>> .description = "ACPI table settings sanity tests.",
>> - .minor_tests = acpi_table_check_tests
>> + .minor_tests = acpi_table_check_tests,
>> };
>
> Any particular reason of this addition comma?
Just a remnant of the original change which added the .init member to do
the feature check. I'll take these out.
Thanks,
Jeremy
More information about the fwts-devel
mailing list