NACK: [PATCH] Remove the x86 specific build constraints for dmicheck

[Colin Ian King]

I've had an update from Linaro. I'll send their patch instead.


On 20/10/14 05:25, Keng-Yu Lin wrote:
> On Sun, Oct 19, 2014 at 1:08 PM, Alex Hung <alex.hung at canonical.com> wrote:
>>
>> On 14-10-18 09:19 PM, Colin King wrote:
>>>
>>> From: Colin Ian King <colin.king at canonical.com>
>>>
>>> Appartently some arm64 systems are being enabled with DMI tables
>>> so enable this test for these systems.
>>>
>>> Signed-off-by: Colin Ian King <colin.king at canonical.com>
>>> ---
>>>   src/dmi/dmicheck/dmicheck.c | 4 ----
>>>   1 file changed, 4 deletions(-)
>>>
>>> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
>>> index e6dee6e..6753a83 100644
>>> --- a/src/dmi/dmicheck/dmicheck.c
>>> +++ b/src/dmi/dmicheck/dmicheck.c
>>> @@ -24,8 +24,6 @@
>>>     #include "fwts.h"
>>>   -#ifdef FWTS_ARCH_INTEL
>>> -
>>>   #include <stdlib.h>
>>>   #include <stdio.h>
>>>   #include <string.h>
>>> @@ -1591,5 +1589,3 @@ static fwts_framework_ops dmicheck_ops = {
>>>   };
>>>     FWTS_REGISTER("dmicheck", &dmicheck_ops, FWTS_TEST_ANYTIME,
>>> FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV)
>>> -
>>> -#endif
>>
>>
>> Yes I also heard that ARM platforms are also implementing DMI.
>>
>> Acked-by: Alex Hung <alex.hung at canonical.com>
>>
> 
> interesting to know this.
> 
> 
> Acked-by: Keng-Yu Lin <kengyu at canonical.com>
>