[V2][PATCH 1/2] acpi: method: _PRS is not mandatory method

Colin Ian King colin.king at canonical.com
Tue Apr 7 10:20:38 UTC 2015


On 07/04/15 06:44, Heyi Guo wrote:
> According to ACPI 5.1 spec, section 6.2.12, "specify a _PRS for all the configurable devices. Static (non-configurable) devices do not specify a _PRS object." So the existance of _PRS method depends on the type of devices, and may be unavailable in some systems.
> 
> Signed-off-by: Heyi Guo <heyi.guo at linaro.org>
> ---
>  src/acpi/method/method.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index e84bd58..cc1ed33 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -2096,7 +2096,7 @@ static int method_test_CRS(fwts_framework *fw)
>  static int method_test_PRS(fwts_framework *fw)
>  {
>  	/* Re-use the _CRS checking on the returned buffer */
> -	return method_evaluate_method(fw, METHOD_MANDITORY,
> +	return method_evaluate_method(fw, METHOD_OPTIONAL,
>  		"_PRS", NULL, 0, method_test_CRS_return, "_PRS");
>  }
>  
> 
Thanks, looks good to me.

Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the fwts-devel mailing list