[PATCH 23/46] hotkey: reduce scope of variables

Keng-Yu Lin keng-yu.lin at canonical.com
Tue Jan 20 06:58:02 UTC 2015


On Wed, Jan 14, 2015 at 3:04 AM, Colin King <colin.king at canonical.com> wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> cppcheck is picking up some minor style issues which can
> be easily fixed:
>
> [src/hotkey/hotkey/hotkey.c:41]:
>         (style) The scope of the variable 'item' can be reduced.
> [src/hotkey/hotkey/hotkey.c:42]:
>         (style) The scope of the variable 'found' can be reduced.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/hotkey/hotkey/hotkey.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/hotkey/hotkey/hotkey.c b/src/hotkey/hotkey/hotkey.c
> index d3f8b7d..f540130 100644
> --- a/src/hotkey/hotkey/hotkey.c
> +++ b/src/hotkey/hotkey/hotkey.c
> @@ -38,8 +38,6 @@ static int hotkey_check_key(fwts_framework *fw,
>         struct input_event *ev, fwts_list *hotkeys)
>  {
>         static int scancode = 0;
> -       fwts_list_link *item;
> -       int found = 0;
>
>         if ((ev->code == MSC_SCAN) &&
>             (ev->type == EV_MSC))
> @@ -47,6 +45,9 @@ static int hotkey_check_key(fwts_framework *fw,
>
>         if ((ev->type == EV_KEY) &&
>             (ev->value != 0)) {
> +               fwts_list_link *item;
> +               int found = 0;
> +
>                 fwts_list_foreach(item, hotkeys) {
>                         fwts_keycode *keycode =
>                                 fwts_list_data(fwts_keycode*, item);
> --
> 2.1.4
>
>
Acked-by: Keng-Yu Lin <kengyu at canonical.com>



More information about the fwts-devel mailing list