ACK: [PATCH] acpi: fadt: check RESET_REG_SUP before checking the reset register

Colin Ian King colin.king at canonical.com
Fri Jul 24 08:25:26 UTC 2015


On 24/07/15 03:41, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>  src/acpi/fadt/fadt.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/acpi/fadt/fadt.c b/src/acpi/fadt/fadt.c
> index abacdb5..8d06d97 100644
> --- a/src/acpi/fadt/fadt.c
> +++ b/src/acpi/fadt/fadt.c
> @@ -305,6 +305,9 @@ static void acpi_table_check_fadt_reset(
>  	const fwts_acpi_table_fadt *fadt,
>  	bool *passed)
>  {
> +	if (!(fadt->flags & FADT_RESET_SUPPORTED))
> +		return;
> +
>  	if (fadt->header.length>=129) {
>  		if ((fadt->reset_reg.address_space_id != 0) &&
>  		    (fadt->reset_reg.address_space_id != 1) &&
> 

Thanks for re-checking the fadt tests Alex.

Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the fwts-devel mailing list