ACK: [PATCH] acpi: correct ACPI BGRT table type
Alex Hung
alex.hung at canonical.com
Wed Jun 24 07:25:51 UTC 2015
On 06/23/2015 05:32 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Fix two mistakes in BGRT, missing header and spelling mistake in the
> image_offset_y field. Update acpidump to cater for the mistake.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
> src/acpi/acpidump/acpidump.c | 2 +-
> src/lib/include/fwts_acpi.h | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/acpi/acpidump/acpidump.c b/src/acpi/acpidump/acpidump.c
> index dce8ba0..c439b80 100644
> --- a/src/acpi/acpidump/acpidump.c
> +++ b/src/acpi/acpidump/acpidump.c
> @@ -1579,7 +1579,7 @@ static void acpidump_bgrt(fwts_framework *fw, const fwts_acpi_table_info *table)
> FIELD_UINT("Image Type", fwts_acpi_table_bgrt, image_type),
> FIELD_UINT("Image Address", fwts_acpi_table_bgrt, image_addr),
> FIELD_UINT("Image Offset X", fwts_acpi_table_bgrt, image_offset_x),
> - FIELD_UINT("Image Offset Y", fwts_acpi_table_bgrt, image_offset_t),
> + FIELD_UINT("Image Offset Y", fwts_acpi_table_bgrt, image_offset_y),
> FIELD_END
> };
>
> diff --git a/src/lib/include/fwts_acpi.h b/src/lib/include/fwts_acpi.h
> index bc2e0ec..63138b9 100644
> --- a/src/lib/include/fwts_acpi.h
> +++ b/src/lib/include/fwts_acpi.h
> @@ -678,12 +678,13 @@ typedef struct {
>
> /* 5.2.22 Boot Graphics Resource Table (BGRT) ACPI 5.0 Spec */
> typedef struct {
> + fwts_acpi_table_header header;
> uint16_t version;
> uint8_t status;
> uint8_t image_type;
> uint64_t image_addr;
> uint32_t image_offset_x;
> - uint32_t image_offset_t;
> + uint32_t image_offset_y;
> } __attribute__ ((packed)) fwts_acpi_table_bgrt;
>
> /* 5.2.23 Firmware Performance Data Table (FPDT) ACPI 5.0 spec */
>
Acked-by: Alex Hung <alex.hung at canonical.com>
More information about the fwts-devel
mailing list