ACK: [PATCH] dmicheck: support smbios check for version 2.8.0 (LP: #1418869)

Alex Hung alex.hung at canonical.com
Mon Mar 2 02:18:52 UTC 2015


On 02/06/2015 05:05 PM, Ivan Hu wrote:
> check with all the types on smbios 2.8.0, there is nothing need to be added
> to the dmicheck, add support the dmicheck for the smbios version 2.8.0.
> 
> modified the warning to skipped if the test not supported.
> 
> Signed-off-by: Ivan Hu <ivan.hu at canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index 3d7cd24..17036f8 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -34,7 +34,7 @@
>  #include <unistd.h>
>  #include <limits.h>
>  
> -#define DMI_VERSION			(0x0207)
> +#define DMI_VERSION			(0x0208)
>  #define VERSION_MAJOR(v)		((v) >> 8)
>  #define VERSION_MINOR(v)		((v) & 0xff)
>  
> @@ -1457,7 +1457,7 @@ static void dmicheck_entry(fwts_framework *fw,
>  static int dmi_version_check(fwts_framework *fw, uint16_t version)
>  {
>  	if (version > DMI_VERSION) {
> -		fwts_warning(fw,
> +		fwts_skipped(fw,
>  			"SMBIOS version %" PRIu16 ".%" PRIu16
>  			" is not supported by the dmicheck "
>  			"test. This test only supports SMBIOS version "
> 

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list