[Luv] [LuvOS][FWTS][uefirtauthvar] Test case 12 passed even if UEFI doesn't support authenticated variable

[Colin Ian King]

On 25/03/15 13:34, Matt Fleming wrote:
> On Fri, 13 Mar, at 11:16:06PM, Heyi Guo wrote:
>> Hi all,
>>
>> Test case 12 of uefiauthvar will pass even if UEFI doesn't support
>> authenticated variable, while all other cases in this suite will be
>> skipped.
>>
>> Test case 12 is to test invalid parameter processing of auth var,
>> however, if UEFI doesn't support auth var, it will always return
>> invalid parameter.
>>
>> Below is the log:
>> uefirtauthvar  ;INF Test 11 of 13: Authenticated variable test with invalid
>> uefirtauthvar  ;INF attributes.
>> uefirtauthvar  ;INF Return status: EFI_INVALID_PARAMETER. A parameter was
>> uefirtauthvar  ;INF incorrect.
>> uefirtauthvar  ;INF Test 12 of 13: Test with both authenticated attributes are
>> uefirtauthvar  ;INF set.
>> uefirtauthvar  ;INF Test 13 of 13: Set and delete authenticated variable created
>> uefirtauthvar  ;INF by different key test.
>> uefirtauthvar  ;INF Return status: EFI_INVALID_PARAMETER. A parameter was
>> uefirtauthvar  ;INF incorrect.
>>
>> uefirtauthvar  ;SUM 1 passed, 0 failed, 0 warning, 0 aborted, 12 skipped, 0 info
>> uefirtauthvar  ;SUM only.
>>
>> I think it is more reasonable to have a basic test before any further
>> test to make sure UEFI supports auth var, otherwise all test cases
>> should be skipped. Test 12 being passed is a little confusing.
>>
>> Thanks.
>>
>> Heyi Guo
> 
> Makes sense to me. Would you like to submit a patch to FWTS?
> 

I believe some of following patches sent by Ivan addressed this very issue:

https://lists.ubuntu.com/archives/fwts-devel/2015-March/005933.html
https://lists.ubuntu.com/archives/fwts-devel/2015-March/005934.html
https://lists.ubuntu.com/archives/fwts-devel/2015-March/005935.html

Colin