[PATCH] Start the work of adding ACPI compliance tests

[Alex Hung]

Hi Al,

This is certain a great idea. FWTS has some tests that check multiple
specs or multiple functions within a spec, such as PCIe ASPM (PCIe and
ACPI FADT) and Chassis type (SMBIOS and ACPI FADT), but most of them are
in smaller scope.

Can you share more information on what you are going to do? For example,
is a test called "acpi/reduce_hardware" to be created and to be added to
--acpicompliance for the scenario you provided? If this is the case, can
we add it to acpitests instead of acpicompliance? Of course, nothing
stops us from putting a test in both acpitests and acpicompliance, but a
clear definitions for each will always help. :)

Cheers,
Alex Hung


On 10/24/2015 05:07 AM, Al Stone wrote:
> So, I'd like to start both re-using FWTS tests, and adding new tests, that
> specifically focus on verifying that ACPI tables are in full compliance with
> the ACPI specification.  As I understand it, ACPI tests in FWTS have in the
> past looked for problem spots that were previously encountered, so as not to
> encounter them a second time.  Compliance with the specification may or may
> not be the same thing, so I'd like to separate them out.
> 
> For example, reduced hardware mode cannot really be enforced in Linux.  There
> are reportedly platforms that claim to be reduced hardware but then use the
> fields in tables that the specification says they should not use.  Since these
> are already supported, these platforms are not broken, but they do violate the
> spec.  In that case, I would expect the ACPI tables on such platforms to be
> able to pass --acpitests, but definitely fail --acpicompliance.
> 
> There are similar issues with MADT subtables.  For instance, one platform that
> is supported in Linux uses a subtable ID that is a reserved value, and is not
> able to boot without that subtable.  So again, it would likely pass when using
> the --acpitests option, but it should definitely fail with --acpicompliance.
> 
> If this approach is acceptable, I'll start adding the proper flags to any of
> the existing tests that can be re-used, and I'll submit additional tests as
> soon as I get them writtem.
> 
> 
> Al Stone (1):
>   Add in the notion of ACPI compliance tests.
> 
>  README_SOURCE.txt                |  1 +
>  src/lib/include/fwts_framework.h |  9 +++++----
>  src/lib/src/fwts_framework.c     | 15 +++++++++++----
>  3 files changed, 17 insertions(+), 8 deletions(-)
> 


-- 
Cheers,
Alex Hung