ACK: [PATCH] fix some spelling mistakes in code and sync fwts-tests accordingly

Alex Hung alex.hung at canonical.com
Wed Sep 9 03:19:44 UTC 2015


On 09/08/2015 12:40 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Found a few minor spelling mistakes, fix these as well as sync the
> fwts-tests with these changes too.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  fwts-test/mchi-0001/mchi-0002.log | 6 +++---
>  src/acpi/dbg2/dbg2.c              | 2 +-
>  src/acpi/erst/erst.c              | 2 +-
>  src/acpi/hest/hest.c              | 2 +-
>  src/acpi/mchi/mchi.c              | 2 +-
>  5 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/fwts-test/mchi-0001/mchi-0002.log b/fwts-test/mchi-0001/mchi-0002.log
> index 2b63528..ae92693 100644
> --- a/fwts-test/mchi-0001/mchi-0002.log
> +++ b/fwts-test/mchi-0001/mchi-0002.log
> @@ -27,9 +27,9 @@ mchi            FAILED [HIGH] MCHIInvalidInterfaceType: Test 1, MCHI
>  mchi            Interface Type is 0x01 which is reserved, allowed values
>  mchi            are 0x02..0x08
>  mchi            FAILED [HIGH] MCHIInvalidProtocolIdentifier: Test 1, MCHI
> -mchi            Protocol Indentifier 0xfe which is reserved, allowed
> -mchi            values are 0x00 (Unspecifier), 0x01 (MCTP), 0x02 (IPMI) or
> -mchi            255 (OEM defined)
> +mchi            Protocol Identifier 0xfe which is reserved, allowed values
> +mchi            are 0x00 (Unspecifier), 0x01 (MCTP), 0x02 (IPMI) or 255
> +mchi            (OEM defined)
>  mchi            FAILED [HIGH] MCHIInterruptTypeReservedNonZero: Test 1,
>  mchi            MCHI Interrupt Type 0x80 has some reserved bits [7:2] set,
>  mchi            these should be all zero.
> diff --git a/src/acpi/dbg2/dbg2.c b/src/acpi/dbg2/dbg2.c
> index 1c023a4..3d12efc 100644
> --- a/src/acpi/dbg2/dbg2.c
> +++ b/src/acpi/dbg2/dbg2.c
> @@ -384,7 +384,7 @@ static int dbg2_test1(fwts_framework *fw)
>  		if (!length_ok)
>  			break;
>  
> -		/* ..and onto the next info stucture .. */
> +		/* ..and onto the next info structure .. */
>  		info = (fwts_acpi_table_dbg2_info *)
>  			((uint8_t *)info + info->length);
>  	}
> diff --git a/src/acpi/erst/erst.c b/src/acpi/erst/erst.c
> index 808b8b2..38d702f 100644
> --- a/src/acpi/erst/erst.c
> +++ b/src/acpi/erst/erst.c
> @@ -96,7 +96,7 @@ static int erst_test1(fwts_framework *fw)
>  
>  #if defined(ERST_DEBUG_ENTRY)
>  		/*  Disable this for now, it causes the test to be too verbose */
> -		fwts_log_info_verbatum(fw, "ERST Serialization Instuction Entry %" PRIu32 ":", i);
> +		fwts_log_info_verbatum(fw, "ERST Serialization Instruction Entry %" PRIu32 ":", i);
>  		fwts_log_info_verbatum(fw, "  Serialization Action:     0x%8.8" PRIx8, entry->serialization_action);
>  		fwts_log_info_verbatum(fw, "  Instruction:              0x%8.8" PRIx8, entry->instruction);
>  		fwts_log_info_verbatum(fw, "  Flags:                    0x%8.8" PRIx8, entry->flags);
> diff --git a/src/acpi/hest/hest.c b/src/acpi/hest/hest.c
> index a4e1f6c..ced6199 100644
> --- a/src/acpi/hest/hest.c
> +++ b/src/acpi/hest/hest.c
> @@ -571,7 +571,7 @@ static void hest_check_generic_error_source(
>  	fwts_acpi_table_hest_generic_hardware_error_source *source =
>  		(fwts_acpi_table_hest_generic_hardware_error_source *)*data;
>  
> -	/* Enough data for an empty machine check exceptions stucture? */
> +	/* Enough data for an empty machine check exceptions structure? */
>  	if (*length < (ssize_t)sizeof(fwts_acpi_table_hest_generic_hardware_error_source)) {
>  		fwts_failed(fw, LOG_LEVEL_HIGH,
>  			"HESTGenericHardwareErrorSourceTooShort",
> diff --git a/src/acpi/mchi/mchi.c b/src/acpi/mchi/mchi.c
> index 23d377e..d1682db 100644
> --- a/src/acpi/mchi/mchi.c
> +++ b/src/acpi/mchi/mchi.c
> @@ -110,7 +110,7 @@ static int mchi_test1(fwts_framework *fw)
>  		passed = false;
>  		fwts_failed(fw, LOG_LEVEL_HIGH,
>  			"MCHIInvalidProtocolIdentifier",
> -			"MCHI Protocol Indentifier 0x%2.2" PRIx8 " which is reserved, "
> +			"MCHI Protocol Identifier 0x%2.2" PRIx8 " which is reserved, "
>  			"allowed values are 0x00 (Unspecifier), 0x01 (MCTP), 0x02 (IPMI) or "
>  			"255 (OEM defined)", mchi->protocol_identifier);
>  	}
> 
Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list