ACK: [PATCH] dmi: dmicheck: fix build error on 32 bit builds

Alex Hung alex.hung at canonical.com
Thu Sep 10 02:14:37 UTC 2015


On 09/10/2015 02:29 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Fix the following build issue:
> 
> dmi/dmicheck/dmicheck.c: In function 'dmi_smbios30_sane':
> dmi/dmicheck/dmicheck.c:561:29: error: comparison between
>   signed and unsigned integer expressions [-Werror=sign-compare]
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index 0a8e85e..d0dc183 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -558,7 +558,7 @@ static int dmi_smbios30_sane(fwts_framework *fw, fwts_smbios30_entry *entry)
>  		ptr += struct_length;
>  
>  		/* Scan for end of DMI entry, must be 2 zero bytes */
> -		while (((ptr - table + 1) < table_length) &&
> +		while (((ptr - table + 1) < (ssize_t)table_length) &&
>  		       ((ptr[0] != 0) || (ptr[1] != 0)))
>  				ptr++;
>  		/* Skip over the two zero bytes */
> 

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list