ACK: [PATCH 03/21] FADT: disable SCI_EN and RESET_REG tests when in reduced hardware mode

Colin Ian King colin.king at canonical.com
Tue Feb 9 11:45:56 UTC 2016


On 09/02/16 01:32, Al Stone wrote:
> Whatever values these fields have in them, they are to be ignored when
> ACPI is in reduced hardware mode.  So, check for that mode and skip the
> tests if we are in reduced hardware.
> 
> Signed-off-by: Al Stone <al.stone at linaro.org>
> ---
>  src/acpi/fadt/fadt.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/src/acpi/fadt/fadt.c b/src/acpi/fadt/fadt.c
> index aacf317..cbe8f05 100644
> --- a/src/acpi/fadt/fadt.c
> +++ b/src/acpi/fadt/fadt.c
> @@ -412,6 +412,11 @@ static int fadt_test2(fwts_framework *fw)
>  		fadt->preferred_pm_profile,
>  		FWTS_ACPI_FADT_PREFERRED_PM_PROFILE(fadt->preferred_pm_profile));
>  
> +	if (fwts_acpi_is_reduced_hardware(fadt)) {
> +		fwts_skipped(fw, "In reduced hardware mode, skipping test.");
> +		return FWTS_OK;
> +	}
> +
>  	port = fadt->pm1a_cnt_blk;
>  	width = fadt->pm1_cnt_len * 8;	/* In bits */
>  
> @@ -487,6 +492,11 @@ static int fadt_test2(fwts_framework *fw)
>  
>  static int fadt_test3(fwts_framework *fw)
>  {
> +	if (fwts_acpi_is_reduced_hardware(fadt)) {
> +		fwts_skipped(fw, "In reduced hardware mode, skipping test.");
> +		return FWTS_OK;
> +	}
> +
>  	if ((fadt->header.revision == 1) || (fadt->header.length < 244)) {
>  		fwts_skipped(fw, "Header size indicates an ACPI 1.0 FADT, skipping test.");
>  		return FWTS_SKIP;
> 
Acked-by: Colin Ian King <colin.king at canonucal.com>



More information about the fwts-devel mailing list