ACK: [PATCH 21/21] FADT: remove no longer useful variables from test1

Colin Ian King colin.king at canonical.com
Tue Feb 9 12:34:03 UTC 2016


On 09/02/16 01:33, Al Stone wrote:
> Now that the tests have been resequenced, added to, and generally
> overhauled, clean up some variables in test1 that are no longer
> useful.
> 
> Signed-off-by: Al Stone <al.stone at linaro.org>
> ---
>  src/acpi/fadt/fadt.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/src/acpi/fadt/fadt.c b/src/acpi/fadt/fadt.c
> index 05205cb..fbc71fd 100644
> --- a/src/acpi/fadt/fadt.c
> +++ b/src/acpi/fadt/fadt.c
> @@ -1514,8 +1514,6 @@ static void acpi_table_check_fadt_sleep_status_reg(fwts_framework *fw)
>  
>  static int fadt_test1(fwts_framework *fw)
>  {
> -	bool passed = true;
> -
>  	acpi_table_check_fadt_firmware_ctrl(fw);
>  	acpi_table_check_fadt_dsdt(fw);
>  	acpi_table_check_fadt_reserved(fw);
> @@ -1589,8 +1587,6 @@ static int fadt_test1(fwts_framework *fw)
>  	 */
>  	fwts_log_info(fw, "FADT Hypervisor Vendor Identity is %" PRIu64,
>  		      fadt->hypervisor_id);
> -	if (passed)
> -		fwts_passed(fw, "No issues found in FADT table.");
>  
>  	return FWTS_OK;
>  }
> 
Acked-by: Colin Ian King <colin.king at canonical.com>

Thanks Al for all these improvements.  Are there any fwts-test patches
to come later?

Colin



More information about the fwts-devel mailing list