ACK: [PATCH 06/21] FADT: move log info out of test2, will provide it elsewhere

Alex Hung alex.hung at canonical.com
Wed Feb 17 05:23:14 UTC 2016


On 2016-02-09 09:32 AM, Al Stone wrote:
> In subsequent patches, we will test the PM profile field explicitly,
> so remove code to log the value from test2 and log it when we do the
> direct testing of the value.
>
> Signed-off-by: Al Stone <al.stone at linaro.org>
> ---
>   src/acpi/fadt/fadt.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/src/acpi/fadt/fadt.c b/src/acpi/fadt/fadt.c
> index c4d3915..5106e4e 100644
> --- a/src/acpi/fadt/fadt.c
> +++ b/src/acpi/fadt/fadt.c
> @@ -488,10 +488,6 @@ static int fadt_test2(fwts_framework *fw)
>   	uint32_t port, width, val32;
>   	int ret = FWTS_OK;
>
> -	fwts_log_info(fw, "FADT Preferred PM Profile: %hhu (%s)\n",
> -		fadt->preferred_pm_profile,
> -		FWTS_ACPI_FADT_PREFERRED_PM_PROFILE(fadt->preferred_pm_profile));
> -
>   	if (fwts_acpi_is_reduced_hardware(fadt)) {
>   		fwts_skipped(fw, "In reduced hardware mode, skipping test.");
>   		return FWTS_OK;
>

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list