[PATCH] acpi: madt: clean up some minor style issues detected by cppcheck

Colin King colin.king at canonical.com
Sat Jan 30 14:15:53 UTC 2016


From: Colin Ian King <colin.king at canonical.com>

[src/acpi/madt/madt.c:1185]: (style) The scope of the variable
  'skip' can be reduced.
[src/acpi/madt/madt.c:1187]: (style) The scope of the variable
  'len' can be reduced.
[src/acpi/madt/madt.c:1188]: (style) The scope of the variable
  'passed' can be reduced.

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 src/acpi/madt/madt.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/acpi/madt/madt.c b/src/acpi/madt/madt.c
index 15bfe10..e32b67f 100644
--- a/src/acpi/madt/madt.c
+++ b/src/acpi/madt/madt.c
@@ -1182,10 +1182,8 @@ static int madt_subtables(fwts_framework *fw)
 	struct acpi_madt_subtable_lengths *ms = spec_data;
 	const uint8_t *data = mtable->data;
 	ssize_t length = mtable->length;
-	ssize_t skip;
 	int ii = 0;
-	int len, proper_len;
-	bool passed = true;
+	int proper_len;
 
 	/*
 	 * check the correctness of each subtable type, and whether or
@@ -1206,8 +1204,11 @@ static int madt_subtables(fwts_framework *fw)
 	}
 
 	while (length > (ssize_t)sizeof(fwts_acpi_madt_sub_table_header)) {
+		ssize_t skip = 0;
+		int len;
+		bool passed = true;
+
 		hdr = (fwts_acpi_madt_sub_table_header *)data;
-		skip = 0;
 		ii++;
 
 		data += sizeof(fwts_acpi_madt_sub_table_header);
@@ -1228,7 +1229,6 @@ static int madt_subtables(fwts_framework *fw)
 		}
 
 		/* verify that the length is what we expect */
-		passed = true;
 		if (len == SUBTABLE_VARIABLE) {
 			if (hdr->type == FWTS_ACPI_MADT_LOCAL_SAPIC) {
 				lsapic = (fwts_acpi_madt_local_sapic *)hdr;
-- 
2.7.0




More information about the fwts-devel mailing list