ACK: [PATCH 2/2] uefi: esrt: fix build failure due to lack of header file

Alex Hung alex.hung at canonical.com
Mon Mar 14 02:49:44 UTC 2016


On 2016-03-08 11:35 AM, Ivan Hu wrote:
> -Wformat-security -c -o uefi/esrt/fwts-esrt.o `test -f
> 'uefi/esrt/esrt.c' || echo './'`uefi/esrt/esrt.c
> uefi/esrt/esrt.c: In function ‘check_entries’:
> uefi/esrt/esrt.c:105:6: error: expected ‘)’ before ‘PRIu32’
> uefi/esrt/esrt.c:105:6: error: format ‘%s’ expects a matching ‘char *’
> argument [-Werror=format]
> uefi/esrt/esrt.c:105:6: error: spurious trailing ‘%’ in format
> [-Werror=format]
> uefi/esrt/esrt.c:137:6: error: expected ‘)’ before ‘PRIu32’
> uefi/esrt/esrt.c:137:6: error: spurious trailing ‘%’ in format
> [-Werror=format]
> uefi/esrt/esrt.c:171:6: error: expected ‘)’ before ‘PRIu32’
> uefi/esrt/esrt.c:171:6: error: format ‘%s’ expects a matching ‘char *’
> argument [-Werror=format]
> uefi/esrt/esrt.c:171:6: error: spurious trailing ‘%’ in format
> [-Werror=format]
> uefi/esrt/esrt.c: In function ‘esrt_test1’:
> uefi/esrt/esrt.c:237:4: error: expected ‘)’ before ‘PRIu64’
> uefi/esrt/esrt.c:237:4: error: spurious trailing ‘%’ in format
> [-Werror=format]
> cc1: all warnings being treated as errors
>
> Signed-off-by: Ivan Hu <ivan.hu at canonical.com>
> ---
>   src/uefi/esrt/esrt.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/uefi/esrt/esrt.c b/src/uefi/esrt/esrt.c
> index 7b648c9..69da391 100644
> --- a/src/uefi/esrt/esrt.c
> +++ b/src/uefi/esrt/esrt.c
> @@ -24,6 +24,7 @@
>   #include <errno.h>
>   #include <sys/types.h>
>   #include <dirent.h>
> +#include <inttypes.h>
>
>   #include "fwts_uefi.h"
>
>

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list