ACK: [PATCH 2/6] lib: olog: Show test as skipped if nothing to do
ivanhu
ivan.hu at canonical.com
Mon Oct 17 08:07:23 UTC 2016
On 2016年10月15日 03:17, Jeffrey Hugo wrote:
> If there is nothing for olog to do, the error message states the test is
> skipped, however the test is categorized as aborted. The majority of other
> tests are categorized as skipped under this scenario. Update the init path
> to return a SKIP error to categorize the test result similar to other tests.
>
> Signed-off-by: Jeffrey Hugo <jhugo at codeaurora.org>
> ---
> src/kernel/olog/olog.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/kernel/olog/olog.c b/src/kernel/olog/olog.c
> index bb65279..9d432cd 100644
> --- a/src/kernel/olog/olog.c
> +++ b/src/kernel/olog/olog.c
> @@ -41,7 +41,7 @@ static int olog_init(fwts_framework *fw)
> if (olog == NULL) {
> fwts_log_error(fw, "OLOG without any parameters on the platform you are running does nothing, please specify -o for custom log analysis.\n");
> fwts_log_error(fw, "PPC supports dump and analysis of the default firmware logs.\n");
> - return FWTS_ERROR;
> + return FWTS_SKIP;
> }
> }
>
>
Acked-by: Ivan Hu <ivan.hu at canonical.com>
More information about the fwts-devel
mailing list