[PATCH 1/7] acpi: s3power: remove redundant intialization of fwts_settings

Colin King colin.king at canonical.com
Wed Oct 19 13:26:33 UTC 2016


From: Colin Ian King <colin.king at canonical.com>

Cleans up a cppcheck style warning:
src/acpi/s3power/s3power.c:265]: (style) Variable 'fwts_settings' is
  reassigned a value before the old one has been used.

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 src/acpi/s3power/s3power.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/acpi/s3power/s3power.c b/src/acpi/s3power/s3power.c
index 00995ae..01e3d8c 100644
--- a/src/acpi/s3power/s3power.c
+++ b/src/acpi/s3power/s3power.c
@@ -251,7 +251,7 @@ static int s3power_test(fwts_framework *fw)
 	uint32_t capacity_before_mWh;
 	uint32_t capacity_after_mWh;
 
-	fwts_pm_method_vars *fwts_settings = NULL;
+	fwts_pm_method_vars *fwts_settings;
 
 	int (*do_suspend)(fwts_pm_method_vars *, const int, int*, const char*);
 
-- 
2.9.3




More information about the fwts-devel mailing list