[PATCH 2/7] acpi: s4: remove redundant intialization of fwts_settings

Colin King colin.king at canonical.com
Wed Oct 19 13:26:34 UTC 2016


From: Colin Ian King <colin.king at canonical.com>

Cleans up a cppcheck style warning:
src/acpi/s4/s4.c:188]: (style) Variable 'fwts_settings' is reassigned
a value before the old one has been used.

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 src/acpi/s4/s4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/acpi/s4/s4.c b/src/acpi/s4/s4.c
index ca486c1..72ec9a2 100644
--- a/src/acpi/s4/s4.c
+++ b/src/acpi/s4/s4.c
@@ -181,7 +181,7 @@ static int s4_hibernate(fwts_framework *fw,
 	int rc = FWTS_OK;
 	char *command = NULL;
 	char *quirks = NULL;
-	fwts_pm_method_vars *fwts_settings = NULL;
+	fwts_pm_method_vars *fwts_settings;
 
 	int (*do_s4)(fwts_pm_method_vars *, const int, int*, const char*);
 
-- 
2.9.3




More information about the fwts-devel mailing list