ACK: [PATCH 3/7] acpi: s3: remove redundant intialization of fwts_settings

ivanhu ivan.hu at canonical.com
Mon Oct 24 08:02:53 UTC 2016



On 2016年10月19日 21:26, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Cleans up a cppcheck style warning:
> src/acpi/s3/s3.c:163]: (style) Variable 'fwts_settings' is reassigned
> a value before the old one has been used
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/acpi/s3/s3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acpi/s3/s3.c b/src/acpi/s3/s3.c
> index 2362a78..77d1bc4 100644
> --- a/src/acpi/s3/s3.c
> +++ b/src/acpi/s3/s3.c
> @@ -156,7 +156,7 @@ static int s3_do_suspend_resume(fwts_framework *fw,
>  	int rc = FWTS_OK;
>  	char *command = NULL;
>  	char *quirks = NULL;
> -	fwts_pm_method_vars *fwts_settings = NULL;
> +	fwts_pm_method_vars *fwts_settings;
>
>  	int (*do_suspend)(fwts_pm_method_vars *, const int, int*, const char*);
>
>

Acked-by: Ivan Hu <ivan.hu at canonical.com>



More information about the fwts-devel mailing list