ACK: [PATCH] acpi: einj: fix incorrect addition on cast
Alex Hung
alex.hung at canonical.com
Mon Apr 17 17:33:52 UTC 2017
On 2017-04-13 03:23 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> I believe the original intent was to cast the pointer to char *, add 48
> and cast the result to fwts_acpi_serialization_instruction_entries *. Fix
> this by adding parenthesis around the char * addition part.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
> src/acpi/einj/einj.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acpi/einj/einj.c b/src/acpi/einj/einj.c
> index f585776e..8b0f5a03 100644
> --- a/src/acpi/einj/einj.c
> +++ b/src/acpi/einj/einj.c
> @@ -82,7 +82,7 @@ static int einj_test1(fwts_framework *fw)
> fwts_log_nl(fw);
>
> entry = (fwts_acpi_serialization_instruction_entries *)
> - (char *) einj + 48;
> + (char *)(einj + 48);
> for (i = 0; i < einj->count; i++, entry++) {
> fwts_acpi_gas gas = entry->register_region;
> fwts_log_info_verbatim(fw, " Injection Instruction Entry %2.2"
>
Acked-by: Alex Hung <alex.hung at canonical.com>
More information about the fwts-devel
mailing list