ACK: [PATCH 1/3] acpi: dbg2: sbbr: allow PL011 UART as a valid subtype

[ivanhu]

On 12/19/2017 02:28 AM, Sakar Arora wrote:
> The ARM PL011 UART is a superset of ARM SBSA UART and some ARM server
> implementations use it.
>
> Signed-off-by: Sakar Arora <sakar.arora at arm.com>
> ---
>  src/acpi/dbg2/dbg2.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/src/acpi/dbg2/dbg2.c b/src/acpi/dbg2/dbg2.c
> index b826c27..eef5ee7 100644
> --- a/src/acpi/dbg2/dbg2.c
> +++ b/src/acpi/dbg2/dbg2.c
> @@ -28,8 +28,9 @@
>  
>  #include "fwts_acpi_object_eval.h"
>  
> -#define SBBR_DBG2_PORT_SERIAL   0x8000
> -#define SBBR_DBG2_ARM_SBSA_UART 0x000E
> +#define SBBR_DBG2_PORT_SERIAL     0x8000
> +#define SBBR_DBG2_ARM_SBSA_UART   0x000E
> +#define SBBR_DBG2_ARM_PL011_UART  0x0003
>  
>  static fwts_acpi_table_info *table;
>  
> @@ -71,8 +72,9 @@ static int dbg2_test2(fwts_framework *fw)
>  			break;
>  		if (((uint8_t*)info + info->length) >= ((uint8_t*)table + table->length))
>  			break;
> -		if ((info->port_type == SBBR_DBG2_PORT_SERIAL) &&
> -		(info->port_subtype == SBBR_DBG2_ARM_SBSA_UART)) {
> +		if (info->port_type == SBBR_DBG2_PORT_SERIAL &&
> +		   (info->port_subtype == SBBR_DBG2_ARM_SBSA_UART ||
> +		    info->port_subtype == SBBR_DBG2_ARM_PL011_UART)) {
>  			fwts_passed(fw,
>  				"DBG2 provides a standard serial debug "
>  				"port and describes ARM SBSA Generic UART");
Acked-by: Ivan Hu <ivan.hu at canonical.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20171219/5c08a7f1/attachment.html>