[PATCH 00/12] *** SBBR Test Cases ***

[Supreeth Venkatesh]

On Fri, 2017-03-03 at 12:56 -0700, Al Stone wrote:
> On 03/02/2017 03:26 PM, Supreeth Venkatesh wrote:
> > 
> > This Server Base Boot Requirements (SBBR) specification is intended
> > for SBSA-compliant 64-bit ARMv8 servers. 
> > It defines the base firmware requirements for out-of-box support of
> > any ARM SBSA-compatible Operating System or hypervisor. 
> > The requirements in this specification are expected to be minimal
> > yet complete for booting a multi-core ARMv8 server platform, while
> > leaving plenty of room 
> > for OEM or ODM innovations and design details.
> > For more information, download the SBBR specification
> > 
> > This specification is closely aligned with ACPI 6.0 Specification.
> > However, there are slight variations in some of the test cases.
> > 
> > To handle these variations, command line switch "--sbbr" has been
> > introduced and that patch has already been acknowledged.
> > The below patchset will add the additional test cases or
> > modifications to existing test cases by separating/seggregating 
> > all SBBR ACPI and SMBIOS test cases at one place in the folder
> > src/sbbr.
> > 
> > 
> > Supreeth Venkatesh (12):
> >   sbbr: Add "FWTS_HAS_SBBR" define for AArch64.
> >   sbbr/acpitables: Add tests to check for recommended acpi tables.
> >   sbbr/dbg2: Add test cases to dbg2 acpi table as per SBBR.
> >   sbbr/dmicheck: Add SMBIOS test cases as per SBBR.
> >   sbbr/fadt: Add additional tests cases to fadt table as per SBBR.
> >   sbbr/gtdt: Add tests to gtdt acpi table as per sbbr.
> >   sbbr/madt: Add initial tests to madt acpi table as per sbbr.
> >   sbbr/rsdp: Add initial rsdp acpi tests as per sbbr.
> >   sbbr/spcr: Add initial tests to spcr acpi table as per sbbr.
> >   sbbr/xsdt: Add initial tests to xsdt acpi table as per sbbr.
> >   sbbr/method: Add initial tests to acpi method tests as per sbbr.
> >   sbbr: Add initial sbbr test case files.
> > 
> >  src/Makefile.am                  |   10 +
> >  src/lib/include/fwts.h           |    1 +
> >  src/sbbr/acpitables/acpitables.c |  328 ++
> >  src/sbbr/dbg2/dbg2.c             |  388 ++
> >  src/sbbr/dmicheck/dmicheck.c     | 1625 +++++++++
> >  src/sbbr/fadt/fadt.c             |  417 +++
> >  src/sbbr/gtdt/gtdt.c             |  253 ++
> >  src/sbbr/madt/madt.c             |  965 +++++
> >  src/sbbr/method/method.c         | 7333
> > ++++++++++++++++++++++++++++++++++++++
> >  src/sbbr/rsdp/rsdp.c             |  134 +
> >  src/sbbr/spcr/spcr.c             |  343 ++
> >  src/sbbr/xsdt/xsdt.c             |   90 +
> >  12 files changed, 11887 insertions(+)
> >  create mode 100644 src/sbbr/acpitables/acpitables.c
> >  create mode 100644 src/sbbr/dbg2/dbg2.c
> >  create mode 100644 src/sbbr/dmicheck/dmicheck.c
> >  create mode 100644 src/sbbr/fadt/fadt.c
> >  create mode 100644 src/sbbr/gtdt/gtdt.c
> >  create mode 100644 src/sbbr/madt/madt.c
> >  create mode 100644 src/sbbr/method/method.c
> >  create mode 100644 src/sbbr/rsdp/rsdp.c
> >  create mode 100644 src/sbbr/spcr/spcr.c
> >  create mode 100644 src/sbbr/xsdt/xsdt.c
> > 
> If I didn't see them, my apologies.  However, I don't recall seeing
> any checking to make sure the tests are running on ARMv8 hardware.  I
> suppose since they are only built on ARMv8, that might be okay, but
> I can easily see a scenario where I am running the tests on my x86
> laptop to check firmware destined for an arm64 machine.  Personally,
> I'd like to see such checks if they make sense.
It executes only on AARCh64, please check 
sbbr: Add "FWTS_HAS_SBBR" define for AArch64. on x86 Machines, test
cases are not registered.
> 
> If the alternative is to send me an arm64 laptop, that would be even
> better :-).
> 
I wish I can have arm64 laptop too :)

Supreeth