[PATCH 04/12] sbbr/dmicheck: Add SMBIOS test cases as per SBBR.

Supreeth Venkatesh supreeth.venkatesh at arm.com
Mon Mar 6 17:48:00 UTC 2017


On Thu, 2017-03-02 at 23:23 +0000, Colin Ian King wrote:
> I get white space errors when applying this patch:
> 
> Applying: sbbr/dmicheck: Add SMBIOS test cases as per SBBR.
> .git/rebase-apply/patch:1555: space before tab in indent.
>     		(entry_data < (table + table_max_length)) )
> .git/rebase-apply/patch:1557: space before tab in indent.
>     	hdr = (fwts_dmi_header *)(entry_data);
> warning: 2 lines add whitespace errors.
> 
Ok. will fix it.
> This does seem like a cut-n-paste duplication of a lot of the fwts
> smbios checking code. What's different about this that justifies
> duplication of code?
> 
> 
SBBR Starts from SMBIOS(DTMF) 3.0, hence legacy SMBIOS v1.0 APIs are
removed. also additional test cases are added.



More information about the fwts-devel mailing list