[PATCH 02/12] sbbr/acpitables: Add tests to check for recommended acpi tables.

Jeffrey Hugo jhugo at codeaurora.org
Mon Mar 6 19:10:07 UTC 2017


On 3/6/2017 10:45 AM, Supreeth Venkatesh wrote:
> On Thu, 2017-03-02 at 16:18 -0700, Jeffrey Hugo wrote:
>> On 3/2/2017 3:26 PM, Supreeth Venkatesh wrote:
>>>

>>> +
>>> +#define TABLE_NAME_LEN (16)
>>> +#define MIN_SIG        ( 4)
>>> +#define OEM_ID         ( 6)
>>> +#define OEM_TABLE_ID   ( 8)
>>> +#define OEM_CREATOR_ID ( 4)
>> I find it hard to believe that these standard ACPI header field
>> defines
>> are not defined anywhere else in the whole of FWTS.
> At the time of developing these were not there and there were no
> compilation/link issues with the latest master, so no these are not
> defined anywhere.

Ok, I guess I was wrong.  These feel like things that should be in a 
header file, since they are common to every ACPI table.

-- 
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm 
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.



More information about the fwts-devel mailing list