[PATCH 11/12] sbbr/method: Add initial tests to acpi method tests as per sbbr.

Jeffrey Hugo jhugo at codeaurora.org
Mon Mar 6 19:12:47 UTC 2017


On 3/6/2017 10:39 AM, Supreeth Venkatesh wrote:
> On Thu, 2017-03-02 at 23:57 +0000, Colin Ian King wrote:
>> This is duplication of the fwts method test. What's the
>> justification?
>> Cut-n-paste duplication makes maintenance really hard work.
> Please suggest alternate method from maintainability aspect.
> I could actually use "FWTS_HAS_SBBR" Pre-Compiler Switch to
> differentiate from the normal flow, but then again it wont be nicely
> separated and all sbbr test cases will not be in one place.
> Please suggest and I will make changes as per your feedback.

Is it possible to integrate the SBBR content into the existing tests 
with a runtime switch so that the existing tests go through the 
existing, normal flow by default, and the SBBR flow when --sbbr is given 
on the command line?

>>
>> On 02/03/17 22:26, Supreeth Venkatesh wrote:
>>>
>>> Server Base Boot Requirements (SBBR) specification is intended for
>>> SBSA-
>>> compliant 64-bit ARMv8 servers.
>>> It defines the base firmware requirements for out-of-box support of
>>> any
>>> ARM SBSA-compatible Operating System or hypervisor.
>>> The requirements in this specification are expected to be minimal
>>> yet
>>> complete for booting a multi-core ARMv8 server platform, while
>>> leaving
>>> plenty of room for OEM or ODM innovations and design details.
>>> For more information, download the SBBR specification here:
>>> http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.den0044
>>> b/index.html
>>>
>>> This change introduces test cases as per SBBR specification to acpi
>>> method tests. These test cases may be subset/superset of acpi
>>> method
>>> tests already existing. However, to preserve "sbbr" classification,
>>> new
>>> file is created, even when most of the code is re-used from
>>> acpi/method.
>>>
>>> Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh at arm.com>
>>> ---
>>>
>


-- 
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm 
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.



More information about the fwts-devel mailing list