[PATCH 09/12] sbbr/spcr: Add initial tests to spcr acpi table as per sbbr.

[Colin Ian King]

On 06/03/17 18:03, Supreeth Venkatesh wrote:
> On Thu, 2017-03-02 at 23:54 +0000, Colin Ian King wrote:
>> Again, this seems to be a duplication of the fwts spcr test, why the
>> duplication?
>>
> Yes. There is some code reused. To segregate all SBBR tests in one
> place, this has been done. If it's a maintainability issue, please
> suggest whether to use pre-compiler switch "FWTS_HAS_SBBR" in existing
> file.

Sorry to take so long to reply, I overlooked this question.

I suggest using the --sbbr flag to enable/disable the SBBR functionality
in the existing tests. The --sbbr option sets fw->flags with bit flag
FWTS_FLAG_TEST_SBBR, so simply use something like:

	if (fw->flags & FWTS_FLAG_TEST_SBBR) {
		/* SBBR specific code */
	} else {
		/* Non-SBBR specific code */
	}

Colin

> 
>> On 02/03/17 22:26, Supreeth Venkatesh wrote:
>>>
>>> Server Base Boot Requirements (SBBR) specification is intended for
>>> SBSA-
>>> compliant 64-bit ARMv8 servers.
>>> It defines the base firmware requirements for out-of-box support of
>>> any
>>> ARM SBSA-compatible Operating System or hypervisor.
>>> The requirements in this specification are expected to be minimal
>>> yet
>>> complete for booting a multi-core ARMv8 server platform, while
>>> leaving
>>> plenty of room for OEM or ODM innovations and design details.
>>> For more information, download the SBBR specification here:
>>> http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.den0044
>>> b/index.html
>>>
>>> This change introduces test cases as per SBBR specification to spcr
>>> acpi
>>> table. These test cases may be subset/superset of spcr acpi table
>>> tests
>>> already existing. However, to preserve "sbbr" classification, new
>>> file
>>> is created, even when most of the code is re-used from acpi/spcr.
>>> It adds additional tests including revision check and GSIV check
>>> tests.
>>>
>>> Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh at arm.com>