ACK: [PATCH 3/3] dmi: dmicheck: add checks for new type 43

Colin Ian King colin.king at canonical.com
Mon May 15 08:19:28 UTC 2017


On 13/05/17 00:34, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index 85b49d5..9471d70 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1801,10 +1801,18 @@ static void dmicheck_entry(fwts_framework *fw,
>  					data[0x4], table, addr, "Reference Designation", 0x4);
>  			break;
>  
> -		case 126: /* 7.44 */
> +		case 43: /* 7.44 */
> +			table = "TPM Device (Type 43)";
> +			if (hdr->length < 0x16)
> +				break;
> +			dmi_str_check(fw, table, addr, "Description", hdr, 0x12);
> +			dmi_reserved_bits_check(fw, table, addr, "Characteristics", hdr, sizeof(uint64_t), 0x13, 6, 63);
> +			break;
> +
> +		case 126: /* 7.45 */
>  			table = "Inactive (Type 126)";
>  			break;
> -		case SMBIOS_END_OF_TABLE: /* 7.45 */
> +		case SMBIOS_END_OF_TABLE: /* 7.46 */
>  			table = "End of Table (Type 127)";
>  			break;
>  		default:
> 
Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the fwts-devel mailing list